[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #23142: chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled

["Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #23142:
URL: https://github.com/apache/superset/pull/23142#discussion_r1114698776


##########
superset-frontend/src/dashboard/actions/sliceEntities.js:
##########
@@ -56,6 +57,16 @@ export function fetchSlices(
     ? [{ col: 'slice_name', opr: 'chart_all_text', value: filter_value }]
     : [];
 
+  if (isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS)) {
+    additional_filters.push({
+      col: 'viz_type',
+      opr: 'neq',
+      value: 'filter_box',
+    });
+  }
+
+  isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS);

Review Comment:
   Should be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org