You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/04/24 11:24:21 UTC

Review Request 20660: Fixed issues for CLOUDSTACK-6489

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
-------

1. Fixed issue mentioned in CLOUDSTACK-6489.
2. There were few indentation issues, fixed them as well.


Diffs
-----

  test/integration/smoke/test_deploy_vm.py 6a8d8e2 
  test/integration/smoke/test_disk_offerings.py 42c950b 
  test/integration/smoke/test_volumes.py 127a721 
  tools/marvin/marvin/config/test_data.py 711227c 
  tools/marvin/marvin/marvinInit.py ba7c4de 
  tools/marvin/marvin/marvinLog.py 6168987 
  tools/marvin/marvin/marvinPlugin.py ae839e8 

Diff: https://reviews.apache.org/r/20660/diff/


Testing
-------

Tested pep8, deployed a datacenter with new changes, ran few tests, verified logs are accumulated as mentioned.


Thanks,

Santhosh Edukulla

Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41278
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> -------
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41280
-----------------------------------------------------------


Commit ef9e2a9367d4990631209322cdc9516fa8c91c28 in cloudstack's branch refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef9e2a9 ]

Fixed issues in CLOUDSTACK-6489

Fixed issues for CLOUDSTACK-6489
Along with fixed few indent issues.

Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> -------
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41577
-----------------------------------------------------------


Commit 69aa3453904f812bb54d35b99d686643436c69c5 in cloudstack's branch refs/heads/marvin from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=69aa345 ]

Fixed issues in CLOUDSTACK-6489

Fixed issues for CLOUDSTACK-6489
Along with fixed few indent issues.

Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> -------
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41578
-----------------------------------------------------------


Commit 69aa3453904f812bb54d35b99d686643436c69c5 in cloudstack's branch refs/heads/marvin from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=69aa345 ]

Fixed issues in CLOUDSTACK-6489

Fixed issues for CLOUDSTACK-6489
Along with fixed few indent issues.

Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> -------
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41279
-----------------------------------------------------------


Commit ef9e2a9367d4990631209322cdc9516fa8c91c28 in cloudstack's branch refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef9e2a9 ]

Fixed issues in CLOUDSTACK-6489

Fixed issues for CLOUDSTACK-6489
Along with fixed few indent issues.

Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> -------
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>