You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Peter Ent <pe...@adobe.com> on 2016/08/09 21:16:31 UTC
[FlexJS] refactor_sprite branch
Hi,
I've gotten a copy of the refactor_sprite branch. While everything builds (need to skip the tests, though), most of the examples won't build due to the "source" property changing for Image.
Do y'all have an estimate when you might resolve this?
Thanks,
Peter
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
After seeing a number of commits over the weekend, I sync'd Falcon and FlexJS repos and rebuilt. It looks like things are back to normal, but I'll run through more examples.
Thanks!
—peter
From: Alex Harui <ah...@adobe.com>>
Date: Friday, August 12, 2016 at 4:37 PM
To: Peter Ent <pe...@adobe.com>>, "dev@flex.apache.org<ma...@flex.apache.org>" <de...@flex.apache.org>>
Subject: Re: [FlexJS] refactor_sprite branch
Good find. I will take a look.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Peter Ent
Date: Fri, Aug 12, 2016 12:36 PM
To: dev@flex.apache.org<ma...@flex.apache.org>;
Subject:Re: [FlexJS] refactor_sprite branch
I finally tracked this down. The reason, it looks like to me, is something
the cross-compiler is doing.
In Core/…/UIBase.as are lines like this:
COMPILE::JS
{
this.positioner.style.height = value + 'px';
}
which are being cross-compiled to:
this.positioner.style.height = value + Number('px');
Number('px') isn't correct so all of the style widths and heights are not
being set.
—peter
On 8/11/16, 5:21 PM, "Peter Ent" <pe...@adobe.com>> wrote:
>I ran a couple just now.
>
>ChartExample -
>SWF: OK
>JS: No errors but everything is drawn up in the corner on top of each
>other.
>
>CreateJSExample -
>SWF: same problem as before
>JS: Actually works!
>
>DataBindingExample -
>SWF: OK
>JS: No errors, but everything is on top of each other. It runs, but looks
>terrible.
>
>—peter
>
>On 8/11/16, 4:27 PM, "Alex Harui" <ah...@adobe.com>> wrote:
>
>>Looks like nobody found time to merge the Language.string from develop
>>into the refactor-sprite branch.
>>
>>I just did that but didn't test it, but please try the JS versions again.
>>
>>-Alex
>>
>>On 8/11/16, 11:28 AM, "Peter Ent" <pe...@adobe.com>> wrote:
>>
>>>Here's a breakdown of all of the examples except a couple which require
>>>AIR and/or Cordova. Bottom line is that none of the JS versions work,
>>>all
>>>with the same error. The SWF versions have mixed results, but most have
>>>errors.
>>>
>>>ChartExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>CreateJSExample -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>> at
>>>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asj
>>>s
>>>/
>>>f
>>>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.a
>>>s
>>>:
>>>0
>>>]
>>> at
>>>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fr
>>>a
>>>m
>>>e
>>>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:14
>>>6
>>>]
>>> at
>>>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/p
>>>e
>>>n
>>>t
>>>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/co
>>>r
>>>e
>>>/
>>>ApplicationFactory.as:78]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataBindingExample_as -
>>>SWF: TypeError: Error #2023: Class DataBindingExample$ must inherit from
>>>Sprite to link to the root.
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataBindingExample_flat -
>>>SWF: blank screen, no error.
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataGridExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexJSStore -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>> at
>>>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asj
>>>s
>>>/
>>>f
>>>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.a
>>>s
>>>:
>>>0
>>>]
>>> at
>>>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fr
>>>a
>>>m
>>>e
>>>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:14
>>>6
>>>]
>>> at
>>>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/p
>>>e
>>>n
>>>t
>>>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/co
>>>r
>>>e
>>>/
>>>ApplicationFactory.as:78]
>>>JS: Several "Unexpected CSS token." messages; TypeError:
>>>org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexJSStore_jquery -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexWebsiteStatsViewer -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>HelloWorld -
>>>SWF: OK
>>>JSL: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>MapSearch -
>>>SWF: N/A
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>MobileMap -
>>>SWF: VerifyError: Error #1014: Class flash.html::HTMLLoader could not be
>>>found.
>>>
>>> at flash.display::MovieClip/nextFrame()
>>> at
>>>org.apache.flex.core::ApplicationFactory/initHandler()[/Users/pent/dev/f
>>>l
>>>e
>>>x
>>>-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Applic
>>>a
>>>t
>>>i
>>>onFactory.as:66]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>MobileTrader -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>StorageExample -
>>>SWF: N/A
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>StyleExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>TodoListSampleApp -
>>>SWF: Has odd behavior when adding items to the list (large blank space
>>>at
>>>top).
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>TreeExample -
>>>SWF: Had odd behavior when adding items to the list (large blank space
>>>at
>>>top).
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>
>>>
>>>On 8/11/16, 11:39 AM, "Peter Ent" <pe...@adobe.com>> wrote:
>>>
>>>>Thanks. I now have mobile trader working. That example requires
>>>>FALCON_HOME to be set to the compiler directory but I didn't need it
>>>>for
>>>>DataBindingExample. I'll see what others need it. Seems best to avoid
>>>>env
>>>>vars if possible.
>>>>‹peter
>>>>
>>>>On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com>> wrote:
>>>>
>>>>>
>>>>>
>>>>>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com>> wrote:
>>>>>
>>>>>>I have this:
>>>>>>
>>>>>>[echo]
>>>>>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>>>>>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>>>>>
>>>>>>
>>>>>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>>>>>
>>>>>That looks like a leftover from before the maven refactor. Remove the
>>>>>generated folder.
>>>>>
>>>>>In theory, you shouldn't even need environment variables anymore. The
>>>>>scripts should pick good defaults if you have the usual sibling repos
>>>>>in
>>>>>the expected places. If you need to set an environment variable, the
>>>>>READme says to choose flex-falcon/compiler
>>>>>
>>>>>-Alex
>>>>>
>>>>
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
Good find. I will take a look.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Peter Ent
Date: Fri, Aug 12, 2016 12:36 PM
To: dev@flex.apache.org;
Subject:Re: [FlexJS] refactor_sprite branch
I finally tracked this down. The reason, it looks like to me, is something
the cross-compiler is doing.
In Core/…/UIBase.as are lines like this:
COMPILE::JS
{
this.positioner.style.height = value + 'px';
}
which are being cross-compiled to:
this.positioner.style.height = value + Number('px');
Number('px') isn't correct so all of the style widths and heights are not
being set.
—peter
On 8/11/16, 5:21 PM, "Peter Ent" <pe...@adobe.com> wrote:
>I ran a couple just now.
>
>ChartExample -
>SWF: OK
>JS: No errors but everything is drawn up in the corner on top of each
>other.
>
>CreateJSExample -
>SWF: same problem as before
>JS: Actually works!
>
>DataBindingExample -
>SWF: OK
>JS: No errors, but everything is on top of each other. It runs, but looks
>terrible.
>
>—peter
>
>On 8/11/16, 4:27 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>Looks like nobody found time to merge the Language.string from develop
>>into the refactor-sprite branch.
>>
>>I just did that but didn't test it, but please try the JS versions again.
>>
>>-Alex
>>
>>On 8/11/16, 11:28 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>
>>>Here's a breakdown of all of the examples except a couple which require
>>>AIR and/or Cordova. Bottom line is that none of the JS versions work,
>>>all
>>>with the same error. The SWF versions have mixed results, but most have
>>>errors.
>>>
>>>ChartExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>CreateJSExample -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>> at
>>>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asj
>>>s
>>>/
>>>f
>>>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.a
>>>s
>>>:
>>>0
>>>]
>>> at
>>>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fr
>>>a
>>>m
>>>e
>>>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:14
>>>6
>>>]
>>> at
>>>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/p
>>>e
>>>n
>>>t
>>>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/co
>>>r
>>>e
>>>/
>>>ApplicationFactory.as:78]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataBindingExample_as -
>>>SWF: TypeError: Error #2023: Class DataBindingExample$ must inherit from
>>>Sprite to link to the root.
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataBindingExample_flat -
>>>SWF: blank screen, no error.
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataGridExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexJSStore -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>> at
>>>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asj
>>>s
>>>/
>>>f
>>>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.a
>>>s
>>>:
>>>0
>>>]
>>> at
>>>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fr
>>>a
>>>m
>>>e
>>>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:14
>>>6
>>>]
>>> at
>>>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/p
>>>e
>>>n
>>>t
>>>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/co
>>>r
>>>e
>>>/
>>>ApplicationFactory.as:78]
>>>JS: Several "Unexpected CSS token." messages; TypeError:
>>>org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexJSStore_jquery -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexWebsiteStatsViewer -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>HelloWorld -
>>>SWF: OK
>>>JSL: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>MapSearch -
>>>SWF: N/A
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>MobileMap -
>>>SWF: VerifyError: Error #1014: Class flash.html::HTMLLoader could not be
>>>found.
>>>
>>> at flash.display::MovieClip/nextFrame()
>>> at
>>>org.apache.flex.core::ApplicationFactory/initHandler()[/Users/pent/dev/f
>>>l
>>>e
>>>x
>>>-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Applic
>>>a
>>>t
>>>i
>>>onFactory.as:66]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>MobileTrader -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>StorageExample -
>>>SWF: N/A
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>StyleExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>TodoListSampleApp -
>>>SWF: Has odd behavior when adding items to the list (large blank space
>>>at
>>>top).
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>TreeExample -
>>>SWF: Had odd behavior when adding items to the list (large blank space
>>>at
>>>top).
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>
>>>
>>>On 8/11/16, 11:39 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>>
>>>>Thanks. I now have mobile trader working. That example requires
>>>>FALCON_HOME to be set to the compiler directory but I didn't need it
>>>>for
>>>>DataBindingExample. I'll see what others need it. Seems best to avoid
>>>>env
>>>>vars if possible.
>>>>‹peter
>>>>
>>>>On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com> wrote:
>>>>
>>>>>
>>>>>
>>>>>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>>>>
>>>>>>I have this:
>>>>>>
>>>>>>[echo]
>>>>>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>>>>>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>>>>>
>>>>>>
>>>>>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>>>>>
>>>>>That looks like a leftover from before the maven refactor. Remove the
>>>>>generated folder.
>>>>>
>>>>>In theory, you shouldn't even need environment variables anymore. The
>>>>>scripts should pick good defaults if you have the usual sibling repos
>>>>>in
>>>>>the expected places. If you need to set an environment variable, the
>>>>>READme says to choose flex-falcon/compiler
>>>>>
>>>>>-Alex
>>>>>
>>>>
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I finally tracked this down. The reason, it looks like to me, is something
the cross-compiler is doing.
In Core/…/UIBase.as are lines like this:
COMPILE::JS
{
this.positioner.style.height = value + 'px';
}
which are being cross-compiled to:
this.positioner.style.height = value + Number('px');
Number('px') isn't correct so all of the style widths and heights are not
being set.
—peter
On 8/11/16, 5:21 PM, "Peter Ent" <pe...@adobe.com> wrote:
>I ran a couple just now.
>
>ChartExample -
>SWF: OK
>JS: No errors but everything is drawn up in the corner on top of each
>other.
>
>CreateJSExample -
>SWF: same problem as before
>JS: Actually works!
>
>DataBindingExample -
>SWF: OK
>JS: No errors, but everything is on top of each other. It runs, but looks
>terrible.
>
>—peter
>
>On 8/11/16, 4:27 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>Looks like nobody found time to merge the Language.string from develop
>>into the refactor-sprite branch.
>>
>>I just did that but didn't test it, but please try the JS versions again.
>>
>>-Alex
>>
>>On 8/11/16, 11:28 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>
>>>Here's a breakdown of all of the examples except a couple which require
>>>AIR and/or Cordova. Bottom line is that none of the JS versions work,
>>>all
>>>with the same error. The SWF versions have mixed results, but most have
>>>errors.
>>>
>>>ChartExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>CreateJSExample -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>> at
>>>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asj
>>>s
>>>/
>>>f
>>>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.a
>>>s
>>>:
>>>0
>>>]
>>> at
>>>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fr
>>>a
>>>m
>>>e
>>>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:14
>>>6
>>>]
>>> at
>>>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/p
>>>e
>>>n
>>>t
>>>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/co
>>>r
>>>e
>>>/
>>>ApplicationFactory.as:78]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataBindingExample_as -
>>>SWF: TypeError: Error #2023: Class DataBindingExample$ must inherit from
>>>Sprite to link to the root.
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataBindingExample_flat -
>>>SWF: blank screen, no error.
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>DataGridExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexJSStore -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>> at
>>>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asj
>>>s
>>>/
>>>f
>>>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.a
>>>s
>>>:
>>>0
>>>]
>>> at
>>>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fr
>>>a
>>>m
>>>e
>>>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:14
>>>6
>>>]
>>> at
>>>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/p
>>>e
>>>n
>>>t
>>>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/co
>>>r
>>>e
>>>/
>>>ApplicationFactory.as:78]
>>>JS: Several "Unexpected CSS token." messages; TypeError:
>>>org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexJSStore_jquery -
>>>SWF: TypeError: Error #1007: Instantiation attempted on a
>>>non-constructor.
>>> at org.apache.flex.core::UIHTMLElementWrapper/get
>>>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex
>>>/
>>>o
>>>r
>>>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>FlexWebsiteStatsViewer -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>HelloWorld -
>>>SWF: OK
>>>JSL: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>MapSearch -
>>>SWF: N/A
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>MobileMap -
>>>SWF: VerifyError: Error #1014: Class flash.html::HTMLLoader could not be
>>>found.
>>>
>>> at flash.display::MovieClip/nextFrame()
>>> at
>>>org.apache.flex.core::ApplicationFactory/initHandler()[/Users/pent/dev/f
>>>l
>>>e
>>>x
>>>-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Applic
>>>a
>>>t
>>>i
>>>onFactory.as:66]
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>MobileTrader -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>StorageExample -
>>>SWF: N/A
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>StyleExample -
>>>SWF: OK
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>TodoListSampleApp -
>>>SWF: Has odd behavior when adding items to the list (large blank space
>>>at
>>>top).
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>TreeExample -
>>>SWF: Had odd behavior when adding items to the list (large blank space
>>>at
>>>top).
>>>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>>>
>>>
>>>
>>>
>>>On 8/11/16, 11:39 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>>
>>>>Thanks. I now have mobile trader working. That example requires
>>>>FALCON_HOME to be set to the compiler directory but I didn't need it
>>>>for
>>>>DataBindingExample. I'll see what others need it. Seems best to avoid
>>>>env
>>>>vars if possible.
>>>>‹peter
>>>>
>>>>On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com> wrote:
>>>>
>>>>>
>>>>>
>>>>>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>>>>
>>>>>>I have this:
>>>>>>
>>>>>>[echo]
>>>>>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>>>>>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>>>>>
>>>>>>
>>>>>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>>>>>
>>>>>That looks like a leftover from before the maven refactor. Remove the
>>>>>generated folder.
>>>>>
>>>>>In theory, you shouldn't even need environment variables anymore. The
>>>>>scripts should pick good defaults if you have the usual sibling repos
>>>>>in
>>>>>the expected places. If you need to set an environment variable, the
>>>>>READme says to choose flex-falcon/compiler
>>>>>
>>>>>-Alex
>>>>>
>>>>
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
Looks like nobody found time to merge the Language.string from develop
into the refactor-sprite branch.
I just did that but didn't test it, but please try the JS versions again.
-Alex
On 8/11/16, 11:28 AM, "Peter Ent" <pe...@adobe.com> wrote:
>Here's a breakdown of all of the examples except a couple which require
>AIR and/or Cordova. Bottom line is that none of the JS versions work, all
>with the same error. The SWF versions have mixed results, but most have
>errors.
>
>ChartExample -
>SWF: OK
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>CreateJSExample -
>SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor.
> at org.apache.flex.core::UIHTMLElementWrapper/get
>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/o
>r
>g/apache/flex/core/UIHTMLElementWrapper.as:117]
> at
>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asjs/
>f
>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.as:
>0
>]
> at
>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fram
>e
>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:146]
> at
>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/pen
>t
>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core
>/
>ApplicationFactory.as:78]
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>DataBindingExample_as -
>SWF: TypeError: Error #2023: Class DataBindingExample$ must inherit from
>Sprite to link to the root.
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>DataBindingExample_flat -
>SWF: blank screen, no error.
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>DataGridExample -
>SWF: OK
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>FlexJSStore -
>SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor.
> at org.apache.flex.core::UIHTMLElementWrapper/get
>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/o
>r
>g/apache/flex/core/UIHTMLElementWrapper.as:117]
> at
>org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asjs/
>f
>rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.as:
>0
>]
> at
>org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/fram
>e
>works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:146]
> at
>org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/pen
>t
>/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core
>/
>ApplicationFactory.as:78]
>JS: Several "Unexpected CSS token." messages; TypeError:
>org.apache.flex.utils.Language.string is not a function.
>
>
>FlexJSStore_jquery -
>SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor.
> at org.apache.flex.core::UIHTMLElementWrapper/get
>model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/o
>r
>g/apache/flex/core/UIHTMLElementWrapper.as:117]
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>FlexWebsiteStatsViewer -
>SWF: OK
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>HelloWorld -
>SWF: OK
>JSL: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>MapSearch -
>SWF: N/A
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>MobileMap -
>SWF: VerifyError: Error #1014: Class flash.html::HTMLLoader could not be
>found.
>
> at flash.display::MovieClip/nextFrame()
> at
>org.apache.flex.core::ApplicationFactory/initHandler()[/Users/pent/dev/fle
>x
>-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Applicat
>i
>onFactory.as:66]
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>MobileTrader -
>SWF: OK
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>StorageExample -
>SWF: N/A
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>StyleExample -
>SWF: OK
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>TodoListSampleApp -
>SWF: Has odd behavior when adding items to the list (large blank space at
>top).
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>TreeExample -
>SWF: Had odd behavior when adding items to the list (large blank space at
>top).
>JS: TypeError: org.apache.flex.utils.Language.string is not a function.
>
>
>
>
>On 8/11/16, 11:39 AM, "Peter Ent" <pe...@adobe.com> wrote:
>
>>Thanks. I now have mobile trader working. That example requires
>>FALCON_HOME to be set to the compiler directory but I didn't need it for
>>DataBindingExample. I'll see what others need it. Seems best to avoid env
>>vars if possible.
>>‹peter
>>
>>On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com> wrote:
>>
>>>
>>>
>>>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>>
>>>>I have this:
>>>>
>>>>[echo]
>>>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>>>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>>>
>>>>
>>>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>>>
>>>That looks like a leftover from before the maven refactor. Remove the
>>>generated folder.
>>>
>>>In theory, you shouldn't even need environment variables anymore. The
>>>scripts should pick good defaults if you have the usual sibling repos in
>>>the expected places. If you need to set an environment variable, the
>>>READme says to choose flex-falcon/compiler
>>>
>>>-Alex
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
Here's a breakdown of all of the examples except a couple which require
AIR and/or Cordova. Bottom line is that none of the JS versions work, all
with the same error. The SWF versions have mixed results, but most have
errors.
ChartExample -
SWF: OK
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
CreateJSExample -
SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor.
at org.apache.flex.core::UIHTMLElementWrapper/get
model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/or
g/apache/flex/core/UIHTMLElementWrapper.as:117]
at
org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asjs/f
rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.as:0
]
at
org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/frame
works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:146]
at
org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/pent
/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/
ApplicationFactory.as:78]
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
DataBindingExample_as -
SWF: TypeError: Error #2023: Class DataBindingExample$ must inherit from
Sprite to link to the root.
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
DataBindingExample_flat -
SWF: blank screen, no error.
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
DataGridExample -
SWF: OK
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
FlexJSStore -
SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor.
at org.apache.flex.core::UIHTMLElementWrapper/get
model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/or
g/apache/flex/core/UIHTMLElementWrapper.as:117]
at
org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asjs/f
rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.as:0
]
at
org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/frame
works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:146]
at
org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/pent
/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/
ApplicationFactory.as:78]
JS: Several "Unexpected CSS token." messages; TypeError:
org.apache.flex.utils.Language.string is not a function.
FlexJSStore_jquery -
SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor.
at org.apache.flex.core::UIHTMLElementWrapper/get
model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/or
g/apache/flex/core/UIHTMLElementWrapper.as:117]
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
FlexWebsiteStatsViewer -
SWF: OK
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
HelloWorld -
SWF: OK
JSL: TypeError: org.apache.flex.utils.Language.string is not a function.
MapSearch -
SWF: N/A
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
MobileMap -
SWF: VerifyError: Error #1014: Class flash.html::HTMLLoader could not be
found.
at flash.display::MovieClip/nextFrame()
at
org.apache.flex.core::ApplicationFactory/initHandler()[/Users/pent/dev/flex
-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Applicati
onFactory.as:66]
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
MobileTrader -
SWF: OK
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
StorageExample -
SWF: N/A
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
StyleExample -
SWF: OK
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
TodoListSampleApp -
SWF: Has odd behavior when adding items to the list (large blank space at
top).
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
TreeExample -
SWF: Had odd behavior when adding items to the list (large blank space at
top).
JS: TypeError: org.apache.flex.utils.Language.string is not a function.
On 8/11/16, 11:39 AM, "Peter Ent" <pe...@adobe.com> wrote:
>Thanks. I now have mobile trader working. That example requires
>FALCON_HOME to be set to the compiler directory but I didn't need it for
>DataBindingExample. I'll see what others need it. Seems best to avoid env
>vars if possible.
>‹peter
>
>On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>
>>
>>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>>
>>>I have this:
>>>
>>>[echo]
>>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>>
>>>
>>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>>
>>That looks like a leftover from before the maven refactor. Remove the
>>generated folder.
>>
>>In theory, you shouldn't even need environment variables anymore. The
>>scripts should pick good defaults if you have the usual sibling repos in
>>the expected places. If you need to set an environment variable, the
>>READme says to choose flex-falcon/compiler
>>
>>-Alex
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
Thanks. I now have mobile trader working. That example requires
FALCON_HOME to be set to the compiler directory but I didn't need it for
DataBindingExample. I'll see what others need it. Seems best to avoid env
vars if possible.
‹peter
On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>
>>I have this:
>>
>>[echo]
>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>
>>
>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>
>That looks like a leftover from before the maven refactor. Remove the
>generated folder.
>
>In theory, you shouldn't even need environment variables anymore. The
>scripts should pick good defaults if you have the usual sibling repos in
>the expected places. If you need to set an environment variable, the
>READme says to choose flex-falcon/compiler
>
>-Alex
>
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I wish when these changes were made a more explicit email would be sent.
Not too long ago I found some other old folder and changed it.
‹peter
On 8/11/16, 11:14 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
>On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>
>>I have this:
>>
>>[echo]
>>FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
>> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>>
>>
>>The build fails if I set FALCON_HOME to the flex-falcon directory.
>
>That looks like a leftover from before the maven refactor. Remove the
>generated folder.
>
>In theory, you shouldn't even need environment variables anymore. The
>scripts should pick good defaults if you have the usual sibling repos in
>the expected places. If you need to set an environment variable, the
>READme says to choose flex-falcon/compiler
>
>-Alex
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
On 8/11/16, 7:24 AM, "Peter Ent" <pe...@adobe.com> wrote:
>I have this:
>
>[echo] FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
> [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
>
>
>The build fails if I set FALCON_HOME to the flex-falcon directory.
That looks like a leftover from before the maven refactor. Remove the
generated folder.
In theory, you shouldn't even need environment variables anymore. The
scripts should pick good defaults if you have the usual sibling repos in
the expected places. If you need to set an environment variable, the
READme says to choose flex-falcon/compiler
-Alex
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I have this:
[echo] FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk
[echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx
The build fails if I set FALCON_HOME to the flex-falcon directory.
—peter
On 8/10/16, 5:14 PM, "Alex Harui" <ah...@adobe.com> wrote:
>Worked for me. Alter the ant script for MobileTrader to spit out the
>FALCON_HOME value.
>
>-Alex
>
>On 8/10/16, 1:58 PM, "Peter Ent" <pe...@adobe.com> wrote:
>
>>I sync'd up with the latest falcon and rebuilt (ant all), rebuild
>>flex-asjs (refactor-sprite branch), rebuild MobileTrader. Running the SWF
>>version I get:
>>VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
>>found.
>>
>>Followed by:
>>
>>ReferenceError: Error #1065: Variable
>>_MobileTrader_org_apache_flex_core_ApplicationFactory is not defined.
>>
>>‹peter
>>
>>
>>On 8/10/16, 3:21 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>
>>>
>>>
>>>>On Aug 10, 2016, at 9:18 PM, Peter Ent <pe...@adobe.com> wrote:
>>>>
>>>>> When I run MobileTrader, the JS version looks OK, but the SWF version
>>>>> gives an immediate error:
>>>>> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not
>>>>>be
>>>>> found.
>>>>
>>>
>>>This indicates you are running and out-of-date Falcon compiler. If
>>>that's
>>>not true, I will take a closer look.
>>>
>>>-Alex
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
Worked for me. Alter the ant script for MobileTrader to spit out the
FALCON_HOME value.
-Alex
On 8/10/16, 1:58 PM, "Peter Ent" <pe...@adobe.com> wrote:
>I sync'd up with the latest falcon and rebuilt (ant all), rebuild
>flex-asjs (refactor-sprite branch), rebuild MobileTrader. Running the SWF
>version I get:
>VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
>found.
>
>Followed by:
>
>ReferenceError: Error #1065: Variable
>_MobileTrader_org_apache_flex_core_ApplicationFactory is not defined.
>
>‹peter
>
>
>On 8/10/16, 3:21 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>>
>>
>>>On Aug 10, 2016, at 9:18 PM, Peter Ent <pe...@adobe.com> wrote:
>>>
>>>> When I run MobileTrader, the JS version looks OK, but the SWF version
>>>> gives an immediate error:
>>>> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not
>>>>be
>>>> found.
>>>
>>
>>This indicates you are running and out-of-date Falcon compiler. If
>>that's
>>not true, I will take a closer look.
>>
>>-Alex
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I sync'd up with the latest falcon and rebuilt (ant all), rebuild
flex-asjs (refactor-sprite branch), rebuild MobileTrader. Running the SWF
version I get:
VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
found.
Followed by:
ReferenceError: Error #1065: Variable
_MobileTrader_org_apache_flex_core_ApplicationFactory is not defined.
‹peter
On 8/10/16, 3:21 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
>>On Aug 10, 2016, at 9:18 PM, Peter Ent <pe...@adobe.com> wrote:
>>
>>> When I run MobileTrader, the JS version looks OK, but the SWF version
>>> gives an immediate error:
>>> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not
>>>be
>>> found.
>>
>
>This indicates you are running and out-of-date Falcon compiler. If that's
>not true, I will take a closer look.
>
>-Alex
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
OK, just pushed a fix for Namespace and Qname.
Scanning our generated JS code shows that many implicit coercions are
still being generated, but as far as I can tell they are all "correct".
We could do more "guessing" like assuming that
someArray[someIndex].substring() is really going to return a string. What
do others think?
Otherwise, we should go fix up stuff like this by using
@flexjsignorecoercion String and writing:
(someArray[someIndex] as String).substring()
It is a classic example of what kinds of things would be caught if we ever
create a "super-strict" mode that warns on every access of type "*" and/or
"Object". It is easy to lose type-safety in ActionScript.
We could also use @flexjsnoimplicitstringconversion but there might be an
advantage to being more strict about types in our code, especially if you
take the time to use typed local variables instead of repeating the "as
String" on more than one line of code. It might allow the JS runtime to
do more type inferencing and speed things up.
Thoughts?
-Alex
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
On 8/10/16, 1:44 PM, "Peter Ent" <pe...@adobe.com> wrote:
>I have the Aug 1 compile. Is the .toString() thing fixed? I'll check it
>out anyway and give it a try.
It looks better, but I think it isn't doing the right thing in Namespace
and Qname yet. It looks like the ConstantBinding issue is fixed.
-Alex
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I have the Aug 1 compile. Is the .toString() thing fixed? I'll check it
out anyway and give it a try.
‹peter
On 8/10/16, 4:03 PM, "Alex Harui" <ah...@adobe.com> wrote:
>I will try to make a unit test out of the test case you cited. In theory
>if the expression resolves to a String no implicit conversion will be
>added. Maybe your expression was XML-ish which doesn't always resolve so
>I might need to special case that.
>
>-Alex
>
>On 8/10/16, 12:54 PM, "Harbs" <ha...@gmail.com> wrote:
>
>>OK. I¹ll take it for a spin when I have some time.
>>
>>Does this address the double toString() methods too? Is it smart enough
>>to only call the Language.string() method when it¹s not otherwise being
>>cast?
>>
>>On Aug 10, 2016, at 10:45 PM, Alex Harui <ah...@adobe.com> wrote:
>>
>>>
>>>
>>> On 8/10/16, 12:24 PM, "Harbs" <ha...@gmail.com> wrote:
>>>
>>>> Alex,
>>>>
>>>> What¹s the state of the implicit coercions in Falcon?
>>>>
>>>> Should I give it another try?
>>>
>>> I pushed an update last night. In theory it only adds coercions on
>>> assignments. It will call Language.string() to do the conversion, so
>>>if
>>> you are working in the sprite branch you will need to sync that change
>>> from flex-asjs's develop branch. And it should support
>>> @flexjsnoimplicitstringconversion to suppress the Language.string
>>>calls.
>>> I didn't change the Number() logic.
>>>
>>> I considered checking for XML expressions and just calling toString(),
>>>but
>>> didn't implement that.
>>>
>>> -Alex
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
I will try to make a unit test out of the test case you cited. In theory
if the expression resolves to a String no implicit conversion will be
added. Maybe your expression was XML-ish which doesn't always resolve so
I might need to special case that.
-Alex
On 8/10/16, 12:54 PM, "Harbs" <ha...@gmail.com> wrote:
>OK. I’ll take it for a spin when I have some time.
>
>Does this address the double toString() methods too? Is it smart enough
>to only call the Language.string() method when it’s not otherwise being
>cast?
>
>On Aug 10, 2016, at 10:45 PM, Alex Harui <ah...@adobe.com> wrote:
>
>>
>>
>> On 8/10/16, 12:24 PM, "Harbs" <ha...@gmail.com> wrote:
>>
>>> Alex,
>>>
>>> What’s the state of the implicit coercions in Falcon?
>>>
>>> Should I give it another try?
>>
>> I pushed an update last night. In theory it only adds coercions on
>> assignments. It will call Language.string() to do the conversion, so if
>> you are working in the sprite branch you will need to sync that change
>> from flex-asjs's develop branch. And it should support
>> @flexjsnoimplicitstringconversion to suppress the Language.string calls.
>> I didn't change the Number() logic.
>>
>> I considered checking for XML expressions and just calling toString(),
>>but
>> didn't implement that.
>>
>> -Alex
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Harbs <ha...@gmail.com>.
OK. I’ll take it for a spin when I have some time.
Does this address the double toString() methods too? Is it smart enough to only call the Language.string() method when it’s not otherwise being cast?
On Aug 10, 2016, at 10:45 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
> On 8/10/16, 12:24 PM, "Harbs" <ha...@gmail.com> wrote:
>
>> Alex,
>>
>> What’s the state of the implicit coercions in Falcon?
>>
>> Should I give it another try?
>
> I pushed an update last night. In theory it only adds coercions on
> assignments. It will call Language.string() to do the conversion, so if
> you are working in the sprite branch you will need to sync that change
> from flex-asjs's develop branch. And it should support
> @flexjsnoimplicitstringconversion to suppress the Language.string calls.
> I didn't change the Number() logic.
>
> I considered checking for XML expressions and just calling toString(), but
> didn't implement that.
>
> -Alex
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
On 8/10/16, 12:24 PM, "Harbs" <ha...@gmail.com> wrote:
>Alex,
>
>What’s the state of the implicit coercions in Falcon?
>
>Should I give it another try?
I pushed an update last night. In theory it only adds coercions on
assignments. It will call Language.string() to do the conversion, so if
you are working in the sprite branch you will need to sync that change
from flex-asjs's develop branch. And it should support
@flexjsnoimplicitstringconversion to suppress the Language.string calls.
I didn't change the Number() logic.
I considered checking for XML expressions and just calling toString(), but
didn't implement that.
-Alex
Re: [FlexJS] refactor_sprite branch
Posted by Harbs <ha...@gmail.com>.
Alex,
What’s the state of the implicit coercions in Falcon?
Should I give it another try?
On Aug 10, 2016, at 10:21 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
>> On Aug 10, 2016, at 9:18 PM, Peter Ent <pe...@adobe.com> wrote:
>>
>>> When I run MobileTrader, the JS version looks OK, but the SWF version
>>> gives an immediate error:
>>> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
>>> found.
>>
>
> This indicates you are running and out-of-date Falcon compiler. If that's
> not true, I will take a closer look.
>
> -Alex
>
Re: [FlexJS] refactor_sprite branch
Posted by Alex Harui <ah...@adobe.com>.
>On Aug 10, 2016, at 9:18 PM, Peter Ent <pe...@adobe.com> wrote:
>
>> When I run MobileTrader, the JS version looks OK, but the SWF version
>> gives an immediate error:
>> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
>> found.
>
This indicates you are running and out-of-date Falcon compiler. If that's
not true, I will take a closer look.
-Alex
Re: [FlexJS] refactor_sprite branch
Posted by Harbs <ha...@gmail.com>.
I was getting the same error on my project. I think it’s from js.swc.
On Aug 10, 2016, at 9:18 PM, Peter Ent <pe...@adobe.com> wrote:
> When I run MobileTrader, the JS version looks OK, but the SWF version
> gives an immediate error:
> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
> found.
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I did a sync again and I'm seeing more errors.
Running the CreateJSExample (which I accidentally skipped yesterday)
yields this on SWF:
TypeError: Error #1007: Instantiation attempted on a non-constructor.
at org.apache.flex.core::UIHTMLElementWrapper/get
model()[/Users/pent/dev/flex-asjs/frameworks/projects/Core/src/main/flex/or
g/apache/flex/core/UIHTMLElementWrapper.as:117]
at
org.apache.flex.core::Application/initHandler()[/Users/pent/dev/flex-asjs/f
rameworks/projects/Core/src/main/flex/org/apache/flex/core/Application.as:0
]
at
org.apache.flex.core::Application/setRoot()[/Users/pent/dev/flex-asjs/frame
works/projects/Core/src/main/flex/org/apache/flex/core/Application.as:146]
at
org.apache.flex.core::ApplicationFactory/deferredFrameHandler()[/Users/pent
/dev/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/core/
ApplicationFactory.as:78]
and the JS version seems to hang the browser to slow it way down.
When I run MobileTrader, the JS version looks OK, but the SWF version
gives an immediate error:
VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be
found.
—peter
On 8/10/16, 11:42 AM, "Peter Ent" <pe...@adobe.com> wrote:
>I'm going to change the examples that have given issues from "source" to
>"url" and post my results.
>
>‹peter
>
>On 8/9/16, 5:31 PM, "Harbs" <ha...@gmail.com> wrote:
>
>>I¹ll be happy to change it back to source if others disagreeŠ
>>
>>On Aug 10, 2016, at 12:30 AM, Harbs <ha...@gmail.com> wrote:
>>
>>> I tried to change that in the examples. I obviously missed some.
>>>
>>> I changed ³source² to ³url². I think that makes more sense.
>>>
>>> On Aug 10, 2016, at 12:16 AM, Peter Ent <pe...@adobe.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I've gotten a copy of the refactor_sprite branch. While everything
>>>>builds (need to skip the tests, though), most of the examples won't
>>>>build due to the "source" property changing for Image.
>>>>
>>>> Do y'all have an estimate when you might resolve this?
>>>>
>>>> Thanks,
>>>> Peter
>>>
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Peter Ent <pe...@adobe.com>.
I'm going to change the examples that have given issues from "source" to
"url" and post my results.
‹peter
On 8/9/16, 5:31 PM, "Harbs" <ha...@gmail.com> wrote:
>I¹ll be happy to change it back to source if others disagreeŠ
>
>On Aug 10, 2016, at 12:30 AM, Harbs <ha...@gmail.com> wrote:
>
>> I tried to change that in the examples. I obviously missed some.
>>
>> I changed ³source² to ³url². I think that makes more sense.
>>
>> On Aug 10, 2016, at 12:16 AM, Peter Ent <pe...@adobe.com> wrote:
>>
>>> Hi,
>>>
>>> I've gotten a copy of the refactor_sprite branch. While everything
>>>builds (need to skip the tests, though), most of the examples won't
>>>build due to the "source" property changing for Image.
>>>
>>> Do y'all have an estimate when you might resolve this?
>>>
>>> Thanks,
>>> Peter
>>
>
Re: [FlexJS] refactor_sprite branch
Posted by Harbs <ha...@gmail.com>.
I’ll be happy to change it back to source if others disagree…
On Aug 10, 2016, at 12:30 AM, Harbs <ha...@gmail.com> wrote:
> I tried to change that in the examples. I obviously missed some.
>
> I changed “source” to “url”. I think that makes more sense.
>
> On Aug 10, 2016, at 12:16 AM, Peter Ent <pe...@adobe.com> wrote:
>
>> Hi,
>>
>> I've gotten a copy of the refactor_sprite branch. While everything builds (need to skip the tests, though), most of the examples won't build due to the "source" property changing for Image.
>>
>> Do y'all have an estimate when you might resolve this?
>>
>> Thanks,
>> Peter
>
Re: [FlexJS] refactor_sprite branch
Posted by Harbs <ha...@gmail.com>.
I tried to change that in the examples. I obviously missed some.
I changed “source” to “url”. I think that makes more sense.
On Aug 10, 2016, at 12:16 AM, Peter Ent <pe...@adobe.com> wrote:
> Hi,
>
> I've gotten a copy of the refactor_sprite branch. While everything builds (need to skip the tests, though), most of the examples won't build due to the "source" property changing for Image.
>
> Do y'all have an estimate when you might resolve this?
>
> Thanks,
> Peter