Re: Review Request 34074: DRILL-3035 Create ControlsInjector interface to enforce implementing methods

[Venki Korukanti <ve...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34074/#review86797
-----------------------------------------------------------

Ship it!


Ship It!

- Venki Korukanti


On May 21, 2015, 3:07 p.m., Sudheesh Katkam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34074/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 3:07 p.m.)
> 
> 
> Review request for drill, Chris Westin and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> [DRILL-3035](https://issues.apache.org/jira/browse/DRILL-3035): Created ControlsInjector interface to enforce method implementations
> + [DRILL-2867](https://issues.apache.org/jira/browse/DRILL-2867): Add ControlsValidator to VALIDATORS only if assertions are enabled
> + return in ExecutionControls ctor if assertions are not enabled
> + added InjectorFactory class to align with the logger pattern
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java e2d5b18 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/AccountingDataTunnel.java 2659464 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 6176f77 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 76dc91c 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java 1f6767c 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java baf9bda 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java e210514 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java 684f715 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java 8871a5f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java e385600 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java 7a6477e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java e268e64 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoRecordReader.java a893da1 
>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/ControlsInjector.java PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/ControlsInjectorFactory.java PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java 639802f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java e3a4ba6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java bf4221e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5d07b49 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java e5e0700 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestCountDownLatchInjection.java c98f54c 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java e3558a1 
>   exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java ba29c58 
> 
> Diff: https://reviews.apache.org/r/34074/diff/
> 
> 
> Testing
> -------
> 
> Currently running unit tests and regression tests
> 
> 
> Thanks,
> 
> Sudheesh Katkam
> 
>