You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/07 01:53:13 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request #90: Add a prefix to the root path
hanahmily opened a new pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90
Add the prefix in case of both modules boot up at the same time to conflict with each other.
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 edited a comment on pull request #90: Add a prefix to the root path
Posted by GitBox <gi...@apache.org>.
lujiajing1126 edited a comment on pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90#issuecomment-1060110820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #90: Add a prefix to the root path
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90#issuecomment-1060110820
In the flagSet, I guess we should use different names since the pflag system dose not accept duplicated flag name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #90: Add a prefix to the root path
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90#issuecomment-1060117238
> In the flagSet, I guess we should use different names since the pflag system dose not accept duplicated flag name.
>
> https://github.com/apache/skywalking-banyandb/blob/7f957627bb893c9bb9360174e32fc886e1f71b64/pkg/run/run.go#L200-L204
thanks for pointing out this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #90: Add a prefix to the root path
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90#issuecomment-1060118829
> > In the flagSet, I guess we should use different names since the pflag system dose not accept duplicated flag name.
> > https://github.com/apache/skywalking-banyandb/blob/7f957627bb893c9bb9360174e32fc886e1f71b64/pkg/run/run.go#L200-L204
>
> thanks for pointing out this.
Then we have to adapt all test cases 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 merged pull request #90: Add a prefix to the root path
Posted by GitBox <gi...@apache.org>.
lujiajing1126 merged pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #90: Add a prefix to the root path
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #90:
URL: https://github.com/apache/skywalking-banyandb/pull/90#issuecomment-1060128661
> Then we have to adapt all test cases 😢
Fixed all cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org