[GitHub] keith-turner commented on issue #979: Make libthrift dependency "provided"

[GitBox <gi...@apache.org>]

keith-turner commented on issue #979: Make libthrift dependency "provided"
URL: https://github.com/apache/fluo/pull/979#issuecomment-353176631
 
 
   Recently I ran into the problem this PR is fixing recently.  I was running [stress test](https://github.com/astralway/stresso) with Fluo 1.2.0-SNAP and Accumulo 1.8.1.  Accumulo 1.8.1 is built against thrift 0.9.3.  The stress test builds a shaded jar containing Fluo and Accumulo for map rduce. 
    Because Fluo depends on thrift 0.9.1 the shaded jar ended up with that version.  This caused problems for the Accumulo client code, it blew up with the following error. 
   
   ```
   Exception in thread "main" java.lang.NoSuchMethodError: org.apache.accumulo.core.tabletserver.thrift.TabletClientService$Client.sendBaseOneway(Ljava/lang/String;Lorg/apache/thrift/TBase;)V
   	at org.apache.accumulo.core.tabletserver.thrift.TabletClientService$Client.send_closeScan(TabletClientService.java:303)
   	at org.apache.accumulo.core.tabletserver.thrift.TabletClientService$Client.closeScan(TabletClientService.java:295)
   	at org.apache.accumulo.core.client.impl.ThriftScanner.getBatchFromServer(ThriftScanner.java:117)
   	at org.apache.accumulo.core.metadata.MetadataLocationObtainer.lookupTablet(MetadataLocationObtainer.java:101)
   	at org.apache.accumulo.core.client.impl.TabletLocatorImpl.lookupTabletLocation(TabletLocatorImpl.java:483)
   	at org.apache.accumulo.core.client.impl.TabletLocatorImpl.lookupTabletLocationAndCheckLock(TabletLocatorImpl.java:654)
   	at org.apache.accumulo.core.client.impl.TabletLocatorImpl._locateTablet(TabletLocatorImpl.java:640)
   	at org.apache.accumulo.core.client.impl.TabletLocatorImpl.locateTablet(TabletLocatorImpl.java:456)
   	at org.apache.accumulo.core.client.impl.ThriftScanner.scan(ThriftScanner.java:247)
   	at org.apache.accumulo.core.client.impl.ScannerIterator$Reader.run(ScannerIterator.java:79)
   	at org.apache.accumulo.core.client.impl.ScannerIterator.hasNext(ScannerIterator.java:150)
   	at org.apache.accumulo.core.metadata.TableMetadataServicer.getTabletLocations(TableMetadataServicer.java:78)
   	at org.apache.accumulo.core.client.impl.TableOperationsImpl.listSplits(TableOperationsImpl.java:570)
   	at stresso.trie.Init.writeSplits(Init.java:227)
   	at stresso.trie.Init.buildTree(Init.java:205)
   	at stresso.trie.Init.run(Init.java:151)
   	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
   	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
   	at stresso.trie.Init.main(Init.java:239)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
   	at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
   ```
   
   I will give these changes a try with the stress test and see if it fixes the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services