[GitHub] [flink] MartijnVisser commented on a diff in pull request #20935: [hotfix][doc] Make referencing custom image clearer for Docker

[GitBox <gi...@apache.org>]

MartijnVisser commented on code in PR #20935:
URL: https://github.com/apache/flink/pull/20935#discussion_r1006769024


##########
docs/content.zh/docs/deployment/resource-providers/standalone/docker.md:
##########
@@ -406,15 +406,15 @@ services:
   You can then start creating tables and queries those.
 
 * Note, that all required dependencies (e.g. for connectors) need to be available in the cluster as well as the client.
-  For example, if you would like to use the Kafka Connector create a custom image with the following Dockerfile
+  For example, if you would like to use the Kafka Connector, you can build a custom image.
+  Create a Dockerfile as follows:
 

Review Comment:
   ```suggestion
     For example, if you would like to use the Kafka Connector, you need to build a custom image.
     Create a Dockerfile containing:
   ```



##########
docs/content.zh/docs/deployment/resource-providers/standalone/docker.md:
##########
@@ -406,15 +406,15 @@ services:
   You can then start creating tables and queries those.
 
 * Note, that all required dependencies (e.g. for connectors) need to be available in the cluster as well as the client.
-  For example, if you would like to use the Kafka Connector create a custom image with the following Dockerfile
+  For example, if you would like to use the Kafka Connector, you can build a custom image.
+  Create a Dockerfile as follows:
 
   ```Dockerfile
   FROM flink:{{< stable >}}{{< version >}}-scala{{< scala_version >}}{{< /stable >}}{{< unstable >}}latest{{< /unstable >}}
   RUN wget -P /opt/flink/lib https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka_2.12/{{< version >}}/flink-sql-connector-kafka_scala{{< scala_version >}}-{{< version >}}.jar
   ```
 
-  and reference it (e.g via the `build`) command in the Dockerfile.
-  and reference it (e.g via the `build`) command in the Dockerfile.
+  and reference this Dockerfile with the `build` command in the `docker-compose.yml` file.

Review Comment:
   Perhaps it better to actually display the `build` command that someone needs to type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org