You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/29 09:03:01 UTC

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1700: Support `create_physical_expr` and `ExecutionContextState` or `DefaultPhysicalPlanner` for faster speed

yjshen commented on a change in pull request #1700:
URL: https://github.com/apache/arrow-datafusion/pull/1700#discussion_r795028433



##########
File path: datafusion/src/execution/context.rs
##########
@@ -1115,9 +1114,14 @@ impl ExecutionConfig {
 /// An instance of this struct is created each time a [`LogicalPlan`] is prepared for
 /// execution (optimized). If the same plan is optimized multiple times, a new
 /// `ExecutionProps` is created each time.
+///
+/// It is important that this structure be cheap to create as it is
+/// done so during predicate pruning and expression simplification

Review comment:
       👍




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org