You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "chovy-3012 (via GitHub)" <gi...@apache.org> on 2026/10/09 07:46:44 UTC

[I] [Improvement][TaskPlugin] Reject whitespace-only scripts in ShellParameters.checkParameters [dolphinscheduler]

chovy-3012 opened a new issue, #18684:
URL: https://github.com/apache/dolphinscheduler/issues/18684

   ## Search before asking
   
   - [x] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   ## Description
   
   `ShellParameters.checkParameters()` only checks `rawScript != null && !rawScript.isEmpty()` without trimming. A whitespace-only script (e.g. `"   \n\t  "`) passes validation and creates a meaningless empty task that wastes scheduling resources.
   
   Fix: change to `rawScript != null && !rawScript.trim().isEmpty()`.
   
   Affected file: `dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParameters.java`
   
   ## Are you willing to submit a PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ## Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement][TaskPlugin] Reject whitespace-only scripts in ShellParameters.checkParameters [dolphinscheduler]

Posted by "zhang-arvin (via GitHub)" <gi...@apache.org>.
zhang-arvin commented on issue #18684:
URL: https://github.com/apache/dolphinscheduler/issues/18684#issuecomment-6077446087

   @zhang-arvin here — I'd like to take this.
   
   Plan: in `ShellParameters.checkParameters()` change the emptiness check to `rawScript != null && !rawScript.trim().isEmpty()` (as suggested in the issue), and add a unit test covering whitespace-only scripts. Affected module: `dolphinscheduler-task-plugin/dolphinscheduler-task-shell`.
   
   Please assign this to me if convenient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement][TaskPlugin] Reject whitespace-only scripts in ShellParameters.checkParameters [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #18684: [Improvement][TaskPlugin] Reject whitespace-only scripts in ShellParameters.checkParameters
URL: https://github.com/apache/dolphinscheduler/issues/18684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org