[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1088: [refactor] change spark base api to java

[GitBox <gi...@apache.org>]

wuchunfu commented on a change in pull request #1088:
URL: https://github.com/apache/incubator-seatunnel/pull/1088#discussion_r786766929



##########
File path: seatunnel-apis/seatunnel-api-spark/src/main/scala/org/apache/seatunnel/spark/BaseSparkTransform.java
##########
@@ -14,20 +14,28 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.seatunnel.spark
 
-import org.apache.spark.sql.{Dataset, Row}
-import org.apache.seatunnel.apis.BaseTransform
-import org.apache.seatunnel.shade.com.typesafe.config.{Config, ConfigFactory}
+package org.apache.seatunnel.spark;
 
-trait BaseSparkTransform extends BaseTransform[SparkEnvironment] {
+import org.apache.seatunnel.apis.BaseTransform;
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+import org.apache.seatunnel.shade.com.typesafe.config.ConfigFactory;
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
 
-  protected var config: Config = ConfigFactory.empty()
+public abstract class BaseSparkTransform implements BaseTransform<SparkEnvironment> {
+    protected Config config = ConfigFactory.empty();
 
-  override def setConfig(config: Config): Unit = this.config = config
+    @Override
+    public void setConfig(Config config) {
+        this.config = config;
+    }
 
-  override def getConfig: Config = config
+    @Override
+    public Config getConfig() {
+        return config;
+    }
 
-  def process(data: Dataset[Row], env: SparkEnvironment): Dataset[Row];
+    public abstract Dataset<Row> process(Dataset<Row>data, SparkEnvironment env);
 

Review comment:
       Please modify `Dataset<Row>data` to `Dataset<Row> data`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org