You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/29 03:28:39 UTC
[GitHub] [apisix] spacewander opened a new pull request #3149: chore: improve HTTPS doc
spacewander opened a new pull request #3149:
URL: https://github.com/apache/apisix/pull/3149
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #3149: chore: improve HTTPS doc
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #3149:
URL: https://github.com/apache/apisix/pull/3149#discussion_r549695077
##########
File path: doc/admin-api.md
##########
@@ -662,10 +662,12 @@ Return response from etcd currently.
|key|True|Private key|https private key||
|certs|False|An array of certificate|when you need to configure multiple certificate for the same domain, you can pass extra https certificates (excluding the one given as cert) in this field||
|keys|False|An array of private key|https private keys. The keys should be paired with certs above||
-|sni|True|Match Rules|https SNI||
+|sni|True, can't be used with `snis`|Match Rules|https SNI||
Review comment:
I think we can remove the field `sni` from doc, we'll only support `snis` in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3149: chore: improve HTTPS doc
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3149:
URL: https://github.com/apache/apisix/pull/3149#discussion_r550123690
##########
File path: doc/admin-api.md
##########
@@ -662,10 +662,12 @@ Return response from etcd currently.
|key|True|Private key|https private key||
|certs|False|An array of certificate|when you need to configure multiple certificate for the same domain, you can pass extra https certificates (excluding the one given as cert) in this field||
|keys|False|An array of private key|https private keys. The keys should be paired with certs above||
-|sni|True|Match Rules|https SNI||
+|sni|True, can't be used with `snis`|Match Rules|https SNI||
Review comment:
@membphis
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3149: chore: improve HTTPS doc
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #3149:
URL: https://github.com/apache/apisix/pull/3149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org