You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:38:57 UTC

[GitHub] [helix] xyuanlu opened a new issue #1503: Remove duplicate subscribeForChanges in CallBackHandler

xyuanlu opened a new issue #1503:
URL: https://github.com/apache/helix/issues/1503


   **Is your feature request related to a problem? Please describe.**
   During code inspection, We found there are multiple subscribeForChanges being called in CallBackHandler.handelChildChange. This leads to longer time spend when process callbacks in zkClient, witch eventually leads to increased PendingCallback queue size.
   
   **Describe the solution you'd like**
   Remove duplicate subscribeForChanges in CallBackHandler and refine the code structure to improve performance. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] xyuanlu closed issue #1503: Remove duplicate subscribeForChanges in CallBackHandler

Posted by GitBox <gi...@apache.org>.
xyuanlu closed issue #1503:
URL: https://github.com/apache/helix/issues/1503


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org