You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "yselkowitz (via GitHub)" <gi...@apache.org> on 2026/08/12 23:00:35 UTC
[PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
yselkowitz opened a new pull request, #449:
URL: https://github.com/apache/qpid-proton/pull/449
As of setuptools 70.1, wheel is not needed even to build wheels, and earlier versions would pull in wheel automatically when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
Posted by "astitcher (via GitHub)" <gi...@apache.org>.
astitcher commented on code in PR #449:
URL: https://github.com/apache/qpid-proton/pull/449#discussion_r3790346809
##########
python/ci_requirements.txt:
##########
Review Comment:
It seems to me that if this PR depends on setuptools 70.1 then this should be in this requirements file!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
Posted by "hroncok (via GitHub)" <gi...@apache.org>.
hroncok commented on code in PR #449:
URL: https://github.com/apache/qpid-proton/pull/449#discussion_r3807384908
##########
python/ci_requirements.txt:
##########
Review Comment:
In the cmake file below, that would be the isolated build option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
Posted by "yselkowitz (via GitHub)" <gi...@apache.org>.
yselkowitz commented on code in PR #449:
URL: https://github.com/apache/qpid-proton/pull/449#discussion_r3807259660
##########
python/ci_requirements.txt:
##########
Review Comment:
@hroncok from your other tickets it was implied that this works with setuptools < 70.1 also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
Posted by "astitcher (via GitHub)" <gi...@apache.org>.
astitcher commented on PR #449:
URL: https://github.com/apache/qpid-proton/pull/449#issuecomment-5372404307
I'm not going to accept this PR at the moment. There is no current benefit to removing wheel from the python build and it will stop the build from working hermetically on many current LTS versions of rpm & debian based systems.
When most LTS systems have setuptools 70.1 or greater then we can revisit this change. But currently this would stop us building on our minimum system versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
Posted by "hroncok (via GitHub)" <gi...@apache.org>.
hroncok commented on code in PR #449:
URL: https://github.com/apache/qpid-proton/pull/449#discussion_r3807373410
##########
python/ci_requirements.txt:
##########
Review Comment:
It was never needed to be specified as a build backend requires. However, that implies building via the pyproject hooks. I don't know how this file is used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] NO-JIRA: [Python] Do not require wheel for building [qpid-proton]
Posted by "astitcher (via GitHub)" <gi...@apache.org>.
astitcher closed pull request #449: NO-JIRA: [Python] Do not require wheel for building
URL: https://github.com/apache/qpid-proton/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org