You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/21 00:13:00 UTC
[jira] [Work logged] (HIVE-24830) Revise RowSchema mutability usage
[ https://issues.apache.org/jira/browse/HIVE-24830?focusedWorklogId=684280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-684280 ]
ASF GitHub Bot logged work on HIVE-24830:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/21 00:12
Start Date: 21/Nov/21 00:12
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #2019:
URL: https://github.com/apache/hive/pull/2019#issuecomment-974730576
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 684280)
Time Spent: 40m (was: 0.5h)
> Revise RowSchema mutability usage
> ---------------------------------
>
> Key: HIVE-24830
> URL: https://issues.apache.org/jira/browse/HIVE-24830
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> RowSchema is essentially a container class for a list of fields.
> * it can be constructed from a "list"
> * the list can be set
> * the list can be accessed
> none of the above methods try to protect the data inside; hence the following could easily happen:
> {code}
> s=o1.getSchema();
> col=s.getCol("favourite")
> col.setInternalName("asd"); // will modify o1 schema
> newSchema.add(col);
> o2.setSchema(newSchema);
> o2.getSchema().get("asd").setInternalName("xxx"); // will modify o1 and o2 schema
> [...]
> {code}
> not sure how much of this is actually cruical; exploratory testrun revealed some cases
> https://github.com/apache/hive/pull/2019
--
This message was sent by Atlassian Jira
(v8.20.1#820001)