You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by an...@apache.org on 2009/10/07 14:42:39 UTC
svn commit: r822698 -
/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
Author: andrey
Date: Wed Oct 7 12:42:39 2009
New Revision: 822698
URL: http://svn.apache.org/viewvc?rev=822698&view=rev
Log:
fixing problem with default listeners in new callback model
Modified:
cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java?rev=822698&r1=822697&r2=822698&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java Wed Oct 7 12:42:39 2009
@@ -75,6 +75,7 @@
*/
public void addDefaultListener(LifecycleListener listener) {
addDefaultListener(LifecycleEvent.POST_ADD, listener, "postAdd");
+ addDefaultListener(LifecycleEvent.PRE_PERSIST, listener, "prePersist");
addDefaultListener(LifecycleEvent.POST_PERSIST, listener, "postPersist");
addDefaultListener(LifecycleEvent.PRE_REMOVE, listener, "preRemove");
addDefaultListener(LifecycleEvent.POST_REMOVE, listener, "postRemove");
Re: svn commit: r822698 - /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
Posted by Andrey Razumovsky <ra...@gmail.com>.
Not yet :)
2009/10/8 Andrus Adamchik <an...@objectstyle.org>
> Nah, just overlooked it during refactoring I guess. Good catch. Thanks for
> fixing it.
>
> Andrus
>
>
> On Oct 8, 2009, at 4:45 PM, Andrey Razumovsky wrote:
>
> Hi Andrus,
>>
>> Was removing prePersist from Lifecycle listener done intentionally?
>>
>> 2009/10/7 <an...@apache.org>
>>
>> Author: andrey
>>> Date: Wed Oct 7 12:42:39 2009
>>> New Revision: 822698
>>>
>>> URL: http://svn.apache.org/viewvc?rev=822698&view=rev
>>> Log:
>>> fixing problem with default listeners in new callback model
>>>
>>> Modified:
>>>
>>>
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>>>
>>> Modified:
>>>
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>>> URL:
>>>
>>> http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java?rev=822698&r1=822697&r2=822698&view=diff
>>>
>>>
>>> ==============================================================================
>>> ---
>>>
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>>> (original)
>>> +++
>>>
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>>> Wed Oct 7 12:42:39 2009
>>> @@ -75,6 +75,7 @@
>>> */
>>> public void addDefaultListener(LifecycleListener listener) {
>>> addDefaultListener(LifecycleEvent.POST_ADD, listener, "postAdd");
>>> + addDefaultListener(LifecycleEvent.PRE_PERSIST, listener,
>>> "prePersist");
>>> addDefaultListener(LifecycleEvent.POST_PERSIST, listener,
>>> "postPersist");
>>> addDefaultListener(LifecycleEvent.PRE_REMOVE, listener,
>>> "preRemove");
>>> addDefaultListener(LifecycleEvent.POST_REMOVE, listener,
>>> "postRemove");
>>>
>>>
>>>
>>>
>>
>> --
>> Andrey
>>
>
>
--
Andrey
Re: svn commit: r822698 - /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
Posted by Andrus Adamchik <an...@objectstyle.org>.
Nah, just overlooked it during refactoring I guess. Good catch. Thanks
for fixing it.
Andrus
On Oct 8, 2009, at 4:45 PM, Andrey Razumovsky wrote:
> Hi Andrus,
>
> Was removing prePersist from Lifecycle listener done intentionally?
>
> 2009/10/7 <an...@apache.org>
>
>> Author: andrey
>> Date: Wed Oct 7 12:42:39 2009
>> New Revision: 822698
>>
>> URL: http://svn.apache.org/viewvc?rev=822698&view=rev
>> Log:
>> fixing problem with default listeners in new callback model
>>
>> Modified:
>>
>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/
>> java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>>
>> Modified:
>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/
>> java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>> URL:
>> http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java?rev=822698&r1=822697&r2=822698&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> ---
>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/
>> java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>> (original)
>> +++
>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/
>> java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>> Wed Oct 7 12:42:39 2009
>> @@ -75,6 +75,7 @@
>> */
>> public void addDefaultListener(LifecycleListener listener) {
>> addDefaultListener(LifecycleEvent.POST_ADD, listener,
>> "postAdd");
>> + addDefaultListener(LifecycleEvent.PRE_PERSIST, listener,
>> "prePersist");
>> addDefaultListener(LifecycleEvent.POST_PERSIST, listener,
>> "postPersist");
>> addDefaultListener(LifecycleEvent.PRE_REMOVE, listener,
>> "preRemove");
>> addDefaultListener(LifecycleEvent.POST_REMOVE, listener,
>> "postRemove");
>>
>>
>>
>
>
> --
> Andrey
Re: svn commit: r822698 - /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
Posted by Andrey Razumovsky <ra...@gmail.com>.
Hi Andrus,
Was removing prePersist from Lifecycle listener done intentionally?
2009/10/7 <an...@apache.org>
> Author: andrey
> Date: Wed Oct 7 12:42:39 2009
> New Revision: 822698
>
> URL: http://svn.apache.org/viewvc?rev=822698&view=rev
> Log:
> fixing problem with default listeners in new callback model
>
> Modified:
>
> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
>
> Modified:
> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
> URL:
> http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java?rev=822698&r1=822697&r2=822698&view=diff
>
> ==============================================================================
> ---
> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
> (original)
> +++
> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/reflect/LifecycleCallbackRegistry.java
> Wed Oct 7 12:42:39 2009
> @@ -75,6 +75,7 @@
> */
> public void addDefaultListener(LifecycleListener listener) {
> addDefaultListener(LifecycleEvent.POST_ADD, listener, "postAdd");
> + addDefaultListener(LifecycleEvent.PRE_PERSIST, listener,
> "prePersist");
> addDefaultListener(LifecycleEvent.POST_PERSIST, listener,
> "postPersist");
> addDefaultListener(LifecycleEvent.PRE_REMOVE, listener,
> "preRemove");
> addDefaultListener(LifecycleEvent.POST_REMOVE, listener,
> "postRemove");
>
>
>
--
Andrey