[jira] [Commented] (YARN-4851) Metric improvements for ATS v1.5 storage components

["Junping Du (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267029#comment-15267029 ] 

Junping Du commented on YARN-4851:
----------------------------------

Patch looks pretty good now. Just a few NITs:
{noformat}
-/** This class tracks metrics for the TimelineDataManager. */
+/**
+ * This class tracks metrics for the TimelineDataManager.
+ * Note: Only ATS v1 writes go through TimelineDataManager. Write related
+ * metrics does not include ATS v1.5 operations.
+ */
{noformat}
Can we explicitly mention there are some ATS v1.5 related metrics in EntityGroupFSTimelineStoreMetrics (with @link)?

In EntityCacheItem.java,
{noformat}
+  // Detail data cache related metrics
+  @Metric("cache storage cache hits")
+  private MutableCounterLong cacheHits;
{noformat}
cacheHits here sounds not accurate. This is actually counter for no need to refresh cache. Can we improve the naming here?

Other looks fine to me.

> Metric improvements for ATS v1.5 storage components
> ---------------------------------------------------
>
>                 Key: YARN-4851
>                 URL: https://issues.apache.org/jira/browse/YARN-4851
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-4851-trunk.001.patch, YARN-4851-trunk.002.patch, YARN-4851-trunk.003.patch
>
>
> We can add more metrics to the ATS v1.5 storage systems, including purging, cache hit/misses, read latency, etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org