[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #375: [FLINK-29327][operator] remove operator config from job runtime config before d…

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #375:
URL: https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r977837521


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -666,7 +668,7 @@ private JarRunResponseBody runJar(
         }
     }
 
-    private JarUploadResponseBody uploadJar(
+    protected JarUploadResponseBody uploadJar(

Review Comment:
   please undo this change I think it's not necessary anymore



##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -624,7 +626,7 @@ protected ClusterClient<String> getClusterClient(Configuration conf) throws Exce
                 conf, clusterId, (c, e) -> new StandaloneClientHAServices(restServerAddress));
     }
 
-    private JarRunResponseBody runJar(
+    protected JarRunResponseBody runJar(

Review Comment:
   please undo this change I think it's not necessary anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org