[GitHub] [incubator-druid] pphust commented on a change in pull request #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true

[GitBox <gi...@apache.org>]

pphust commented on a change in pull request #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true
URL: https://github.com/apache/incubator-druid/pull/8323#discussion_r314927957
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/CachingQueryRunner.java
 ##########
 @@ -92,6 +96,7 @@ public CachingQueryRunner(
     }
 
     if (useCache) {
+      close();
 
 Review comment:
   I agree with you the `close()` should be wrapped in `if (cachedResult != null)` nor` if (useCache=true) `.
   The current fix should meet some problem when useCache=true while populateCache=false. 
   It is weekend in China. I will test it again and update you later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org