[avro] 03/17: AVRO-2454: Fix CA1052 - Static holder types should be Static or NotInheritable

[bl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

blachniet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git

commit 770acd5a5f2de734eb7a6e51ae18ed254b2828f8
Author: Brian Lachniet <bl...@gmail.com>
AuthorDate: Sun Aug 18 11:25:37 2019 -0400

    AVRO-2454: Fix CA1052 - Static holder types should be Static or NotInheritable
---
 lang/csharp/Avro.ruleset                              | 1 -
 lang/csharp/src/apache/main/File/DataFileConstants.cs | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lang/csharp/Avro.ruleset b/lang/csharp/Avro.ruleset
index 446f4a4..3dfafe0 100644
--- a/lang/csharp/Avro.ruleset
+++ b/lang/csharp/Avro.ruleset
@@ -21,7 +21,6 @@
     AVRO-2454: We need to evaluate each of these rules to determine whether we should enforce them.
     We disabled these rules initially to get the code analyzers installed in the project.
     -->
-    <Rule Id="CA1052" Action="Info" />
     <Rule Id="CA1062" Action="Info" />
     <Rule Id="CA1063" Action="Info" />
     <Rule Id="CA1303" Action="Info" />
diff --git a/lang/csharp/src/apache/main/File/DataFileConstants.cs b/lang/csharp/src/apache/main/File/DataFileConstants.cs
index 10fe24f..27b034e 100644
--- a/lang/csharp/src/apache/main/File/DataFileConstants.cs
+++ b/lang/csharp/src/apache/main/File/DataFileConstants.cs
@@ -21,6 +21,9 @@ namespace Avro.File
     /// <summary>
     /// Constants used in data files.
     /// </summary>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design",
+        "CA1052:Static holder types should be Static or NotInheritable",
+        Justification = "Maintain public API")]
     public class DataFileConstants
     {
         /// <summary>