[GitHub] [submarine] ByronHsu commented on a change in pull request #492: SUBMARINE-710. Frontend support for tensorboard

[GitBox <gi...@apache.org>]

ByronHsu commented on a change in pull request #492:
URL: https://github.com/apache/submarine/pull/492#discussion_r558922540



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.ts
##########
@@ -114,4 +121,28 @@ export class ExperimentHomeComponent implements OnInit {
   onInitModal(obj) {
     this.form.initModal(obj.initMode, obj.initFormType, obj.id, obj.spec);
   }
+
+  getTensorboardInfo(period: number, due: number) {

Review comment:
       The limit time is named `due` in timeout() function in rxjs as the following:
   `timeout<T>(due: number | Date, scheduler: SchedulerLike = async): MonoTypeOperatorFunction<T>`
   So I think it kind of makes sense.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org