You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dongnuo123 (via GitHub)" <gi...@apache.org> on 2023/11/03 18:58:24 UTC
[PR] [MINOR] Add genericGroupMaxSize and consumerGroupSessionTimeoutMs to GroupMetadataManager in GroupCoordinatorShard [kafka]
dongnuo123 opened a new pull request, #14700:
URL: https://github.com/apache/kafka/pull/14700
I was trying to migrate `ConsumerBounceTest#testConsumerReceivesFatalExceptionWhenGroupPassesMaxSize` to support the new group coordinator. The test can't pass because generic group max size doesn't change according to the config change.
This pr adds `genericGroupMaxSize` to GroupMetadataManager builder in GroupCoordinatorShard to pass the test, and also adds `consumerGroupSessionTimeoutMs` in case it's needed in the future.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Add genericGroupMaxSize and consumerGroupSessionTimeoutMs to GroupMetadataManager in GroupCoordinatorShard [kafka]
Posted by "dongnuo123 (via GitHub)" <gi...@apache.org>.
dongnuo123 closed pull request #14700: [MINOR] Add genericGroupMaxSize and consumerGroupSessionTimeoutMs to GroupMetadataManager in GroupCoordinatorShard
URL: https://github.com/apache/kafka/pull/14700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Add genericGroupMaxSize and consumerGroupSessionTimeoutMs to GroupMetadataManager in GroupCoordinatorShard [kafka]
Posted by "dongnuo123 (via GitHub)" <gi...@apache.org>.
dongnuo123 commented on PR #14700:
URL: https://github.com/apache/kafka/pull/14700#issuecomment-1795069941
Will put this change into https://github.com/apache/kafka/pull/14675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org