You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/03/31 21:46:04 UTC
[GitHub] [libcloud] Kami opened a new pull request #1445: Various
deploy_node() fixes and improvemetns
Kami opened a new pull request #1445: Various deploy_node() fixes and improvemetns
URL: https://github.com/apache/libcloud/pull/1445
This pull request includes the following fixes and improvements to ``deploy_node()`` functionality.
* Add support for Ed25519 private keys when using paramiko >= 2.2.0.
* Update ``deploy_node()`` so it immediately propagates a fatal exception (e.g. key is password protected, but password is not provided, invalid password is provided for password protected keys, invalid key type is used. Previously we would incorrectly try to retry on such exception which means the exception would only bubble up after retry attempts were exhausted (aka default 600 seconds timeout for deploy node).
* Allow user to specify password for password protected keys by passing ``ssh_key_password`` to ``deploy_node()`` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1445: Various deploy_node()
fixes and improvements
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1445: Various deploy_node() fixes and improvements
URL: https://github.com/apache/libcloud/pull/1445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1445: Various
deploy_node() fixes and improvements
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1445: Various deploy_node() fixes and improvements
URL: https://github.com/apache/libcloud/pull/1445#issuecomment-607285744
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=h1) Report
> Merging [#1445](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/3c7f83f64ee72252a14ddc1e1f8cac4474a0be4b&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `76.85%`.
[](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1445 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 373 373
Lines 78147 78236 +89
Branches 7696 7708 +12
=======================================
+ Hits 67331 67408 +77
- Misses 7910 7919 +9
- Partials 2906 2909 +3
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/base.py](https://codecov.io/gh/apache/libcloud/pull/1445/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9iYXNlLnB5) | `91.89% <20.00%> (-1.82%)` | :arrow_down: |
| [libcloud/test/compute/test\_ssh\_client.py](https://codecov.io/gh/apache/libcloud/pull/1445/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfc3NoX2NsaWVudC5weQ==) | `91.84% <70.27%> (-3.26%)` | :arrow_down: |
| [libcloud/compute/ssh.py](https://codecov.io/gh/apache/libcloud/pull/1445/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9zc2gucHk=) | `78.57% <76.19%> (+3.57%)` | :arrow_up: |
| [libcloud/test/compute/test\_deployment.py](https://codecov.io/gh/apache/libcloud/pull/1445/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZGVwbG95bWVudC5weQ==) | `95.59% <97.22%> (+0.07%)` | :arrow_up: |
| [libcloud/compute/deployment.py](https://codecov.io/gh/apache/libcloud/pull/1445/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kZXBsb3ltZW50LnB5) | `94.93% <100.00%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=footer). Last update [3c7f83f...c2313a3](https://codecov.io/gh/apache/libcloud/pull/1445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services