You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2010/08/26 03:11:02 UTC

DO NOT REPLY [Bug 49825] New: mod_dav PUT treats malformed Content-Range as if it were absent

https://issues.apache.org/bugzilla/show_bug.cgi?id=49825

           Summary: mod_dav PUT treats malformed Content-Range as if it
                    were absent
           Product: Apache httpd-2
           Version: 2.3-HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_dav
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: wiml@omnigroup.com


reference:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/mod_dav.c?revision=
982016&view=markup

In dav_parse_range(), called by dav_method_put(), a failure to parse the
Content-Range request-header is treated the same as if the header were absent.
I think this is wrong for several reasons:

1, Apache's current behavior is pretty much guaranteed to not be the behavior
the client needs or expects; if I'm attempting to patch the middle of a file, I
don't want the server to replace the entire file with the patch and then report
success.

2, although comments in mod_dav.c indicate that the behavior is motivated by
RFC2616 [14.16], the relevant paragraph says: "The recipient of an invalid
byte-content-range-spec MUST ignore it and any content transferred along with
it." In other words, the server is required *not to use* the request
entity-body if it is accompanied by an unparsable Content-Range header.

I think that both RFC2616 and common sense indicate that if dav_parse_range()
cannot parse a Content-Range header, Apache should reject the entire request
(presumably with an HTTP 400 error code).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 49825] mod_dav PUT treats malformed Content-Range as if it were absent

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49825

--- Comment #1 from Wim Lewis <wi...@omnigroup.com> 2010-08-25 21:16:26 EDT ---
(Possibly related: bug 42978)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 49825] mod_dav PUT treats malformed Content-Range as if it were absent

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49825

Stefan Fritsch <sf...@sfritsch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk, RFC

--- Comment #2 from Stefan Fritsch <sf...@sfritsch.de> 2010-10-24 05:05:35 EDT ---
Fixed in trunk in r1026743

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 49825] mod_dav PUT treats malformed Content-Range as if it were absent

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49825

Ruediger Pluem <rp...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Ruediger Pluem <rp...@apache.org> 2011-02-08 06:44:32 EST ---
Backported to 2.2.x as r1068309.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org