You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/08/12 07:29:12 UTC
Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1275
https://issues.apache.org/jira/browse/LENS-1275
Repository: lens
Description
-------
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
Diff: https://reviews.apache.org/r/51032/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/#review145848
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 748)
<https://reviews.apache.org/r/51032/#comment212210>
Should we say query launcher is created in this log? and add "starting to launch" log in run() method?
- Amareshwari Sriramadasu
On Aug. 12, 2016, 7:33 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51032/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 7:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1275
> https://issues.apache.org/jira/browse/LENS-1275
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/51032/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/#review146310
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 756)
<https://reviews.apache.org/r/51032/#comment212684>
Can you move the log after setting seggregation id ?
- Amareshwari Sriramadasu
On Aug. 22, 2016, 7:13 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51032/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 7:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1275
> https://issues.apache.org/jira/browse/LENS-1275
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/51032/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/#review146321
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 22, 2016, 7:30 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51032/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 7:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1275
> https://issues.apache.org/jira/browse/LENS-1275
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/51032/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/
-----------------------------------------------------------
(Updated Aug. 25, 2016, 1:11 p.m.)
Review request for lens.
Bugs: LENS-1275
https://issues.apache.org/jira/browse/LENS-1275
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2f27fc25a604333d8c75e85f3d13b6d0d2b661d4
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4fd4fdb9981db6d9ee4d47e8a3bd30458cb14b02
Diff: https://reviews.apache.org/r/51032/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 1 p.m.)
Review request for lens.
Bugs: LENS-1275
https://issues.apache.org/jira/browse/LENS-1275
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/51032/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 12:43 p.m.)
Review request for lens.
Bugs: LENS-1275
https://issues.apache.org/jira/browse/LENS-1275
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/51032/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/#review145608
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Aug. 12, 2016, 7:33 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51032/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 7:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1275
> https://issues.apache.org/jira/browse/LENS-1275
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/51032/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 51032: LENS-1275: Launch Time should be set before
executeAsync is called on selected driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51032/
-----------------------------------------------------------
(Updated Aug. 12, 2016, 1:03 p.m.)
Review request for lens.
Bugs: LENS-1275
https://issues.apache.org/jira/browse/LENS-1275
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java a1ecaa6000e080b69760a0b24a90d8a6bd7453f2
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/51032/diff/
Testing
-------
Thanks,
Rajat Khandelwal