You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "ironman-star (via GitHub)" <gi...@apache.org> on 2026/06/03 06:45:59 UTC

[PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

ironman-star opened a new pull request, #4424:
URL: https://github.com/apache/flink-cdc/pull/4424

   Jira: https://issues.apache.org/jira/browse/FLINK-39832
   
     OracleTypeUtils.fromDbzColumn mapped NUMBER(p,0) to BIGINT for all precisions, but Debezium encodes p>=19 as DECIMAL(BYTES). The mismatch caused the sink to read a BinaryRecordData pointer as a long, producing a constant garbage PK (171798691841) and collapsing all rows on upsert.
   
     Fix: return DECIMAL(p,0) when p>=19, aligned with Debezium runtime behavior.
   
     Tested with Oracle XE 11.2, NUMBER(19,0) PK, including 19-digit large IDs (9000000000000000001). Snapshot and incremental (INSERT/UPDATE/DELETE) all verified correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "ironman-star (via GitHub)" <gi...@apache.org>.

ironman-star commented on PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424#issuecomment-4714680500

   @lvyanquan I've already fix the OracleMetadataAccessorITCase tests and ask for rerun the CI test again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.

lvyanquan merged PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.

lvyanquan commented on PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424#issuecomment-4658825263

   It would be better if you could add related tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.

lvyanquan commented on PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424#issuecomment-4658781567

   Run 'mvn spotless:apply' to fix these violations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "ironman-star (via GitHub)" <gi...@apache.org>.

ironman-star commented on PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424#issuecomment-4815979172

   @lvyanquan I only modified the code related to the Oracle connector, but I don't know why the PostgreSQL tests are failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "ironman-star (via GitHub)" <gi...@apache.org>.

ironman-star commented on PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424#issuecomment-4660354525

   @lvyanquan Already added the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT [flink-cdc]

Posted by "ironman-star (via GitHub)" <gi...@apache.org>.

ironman-star commented on PR #4424:
URL: https://github.com/apache/flink-cdc/pull/4424#issuecomment-4618379786

   @lvyanquan Would you please review this code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org