You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2016/02/02 08:13:51 UTC

[1/2] cordova-plugin-inappbrowser git commit: handle app store urls in system browser

Repository: cordova-plugin-inappbrowser
Updated Branches:
  refs/heads/master 163f7c5a8 -> 1f190d517


handle app store urls in system browser


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/fa7c46a3
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/fa7c46a3
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/fa7c46a3

Branch: refs/heads/master
Commit: fa7c46a316fa4b773aa75742d9ceb10c40056e53
Parents: 9540f11
Author: PC Dreams (Paulo Cristo) <cr...@gmail.com>
Authored: Tue Jan 5 12:32:47 2016 +0000
Committer: PC Dreams (Paulo Cristo) <cr...@gmail.com>
Committed: Tue Jan 5 12:32:47 2016 +0000

----------------------------------------------------------------------
 src/ios/CDVInAppBrowser.m | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/fa7c46a3/src/ios/CDVInAppBrowser.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index 986cfa9..b7820f3 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -390,7 +390,14 @@
             [self.commandDelegate sendPluginResult:pluginResult callbackId:scriptCallbackId];
             return NO;
         }
-    } else if ((self.callbackId != nil) && isTopLevelNavigation) {
+    } 
+    //if is an app store link, let the system handle it, otherwise it fails to load it
+    else if ([[ url scheme] isEqualToString:@"itms-appss"] || [[ url scheme] isEqualToString:@"itms-apps"]) {
+        [theWebView stopLoading];
+        [self openInSystem:url];
+        return NO;
+    }
+    else if ((self.callbackId != nil) && isTopLevelNavigation) {
         // Send a loadstart event for each top-level navigation (includes redirects).
         CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK
                                                       messageAsDictionary:@{@"type":@"loadstart", @"url":[url absoluteString]}];


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/2] cordova-plugin-inappbrowser git commit: Merge branch 'master' of https://github.com/uareurapid/cordova-plugin-inappbrowser

Posted by pu...@apache.org.
Merge branch 'master' of https://github.com/uareurapid/cordova-plugin-inappbrowser


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/1f190d51
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/1f190d51
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/1f190d51

Branch: refs/heads/master
Commit: 1f190d517fb1a38506c3db68766e4a69ade6f69b
Parents: 163f7c5 fa7c46a
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Mon Feb 1 23:13:13 2016 -0800
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Mon Feb 1 23:13:13 2016 -0800

----------------------------------------------------------------------
 src/ios/CDVInAppBrowser.m | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org