You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/30 17:03:05 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1980: Remove PrimitiveBuilder::finish_dict (#1978)

viirya commented on code in PR #1980:
URL: https://github.com/apache/arrow-rs/pull/1980#discussion_r911261408


##########
arrow/src/array/builder/primitive_builder.rs:
##########
@@ -197,30 +195,6 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
         PrimitiveArray::<T>::from(array_data)
     }
 
-    /// Builds the `DictionaryArray` and reset this builder.
-    pub fn finish_dict(&mut self, values: ArrayRef) -> DictionaryArray<T> {

Review Comment:
   This looks like an API should not public.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org