You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/07/12 06:04:00 UTC
[Bug 5556] New: Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem --
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
Summary: Missing `close()', unavailable `newSVpvn_share()'
function, ;OPTIMIZE' => '-O2' problem --
Product: Spamassassin
Version: 3.2.1
Platform: Sun
OS/Version: Solaris
Status: NEW
Severity: normal
Priority: P5
Component: sa-compile
AssignedTo: dev@spamassassin.apache.org
ReportedBy: aab@purdue.edu
CC: aab@purdue.edu
FWIW - I get a "Not Found" when I click on the above "bug writing guidelines".
Bug: `sa-compile::rule2xs()' function does not close "FILE". The last partial
buffer is not written to the file ("body_0.pm") until `sa-compile' exits but is
required in toto at the time `make' is executed. My patch attached below.
Problem 1: The `newSVpvn_share()' function is used in the generated ".xs" code.
Unfortunately, it didn't become available until the perl-5.7.1 API according to
the "Devel::PPPort" module documentation and I'm using perl-5.6.2. `sa-compile'
needs a "require 5.7.1"?
Problem 2: The code used to generate "Makefile.PL" specifically sets 'OPTIMIZE"
=> '-O2'. Unfortunately, "-O2" doesn't work with the Sun Forte/Studio<nn> C
compilers.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem --
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.2.3 |3.2.4
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] [review] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Missing `close()', |[review] Missing `close()',
|unavailable |unavailable
|`newSVpvn_share()' function,|`newSVpvn_share()' function,
|;OPTIMIZE' => '-O2' problem |;OPTIMIZE' => '-O2' problem
|-- |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] [review] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
------- Additional Comments From jm@jmason.org 2007-09-26 03:23 -------
marking major, since sa-compile is broken on 5.6.x without it
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] [review] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2007-12-16 13:25 -------
committed for 3.2.x: r604709
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] [review] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
------- Additional Comments From felicity@apache.org 2007-12-16 12:49 -------
+1
btw: regarding the bug writing guidelines, yeah, I'll see what I can do about it.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] [review] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes |ready to commit for 3.2
------- Additional Comments From sidney@sidney.com 2007-12-16 02:39 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem --
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
------- Additional Comments From aab@purdue.edu 2007-07-11 21:08 -------
Created an attachment (id=4043)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4043&action=view)
Patch for `sa-compile'.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem --
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
------- Additional Comments From jm@jmason.org 2007-08-19 14:41 -------
Created an attachment (id=4099)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4099&action=view)
possible fix
Thanks for the bug report, and the partial fix ;) Could you try this out? It
should fix all 3 issues...
now in trunk:
: jm 176...; svn commit -m "bug 5556: missing close call; newSVpvn_share() is
unavailable in perls before 5.7.1; and we cannot assume that -O2 is a valid
compiler optimization flag due to ancient Sun compiler team idiocy, so use
Config{optimize} instead" sa-compile.raw
Sending sa-compile.raw
Transmitting file data .
Committed revision 567481.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] [review] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 votes
------- Additional Comments From spamassassin@dostech.ca 2007-11-06 12:12 -------
%$*#, I wish people would follow up on bugs they report.
In any case it looks OK, so +1.
(In reply to comment #0)
> FWIW - I get a "Not Found" when I click on the above "bug writing guidelines".
THEO -- if you still have access to the Bugzilla installation could you please
at least remove the bug writing link, or better, point it at a (possibly
non-existent) Wiki page?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5556] Missing `close()', unavailable `newSVpvn_share()' function, ;OPTIMIZE' => '-O2' problem --
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5556
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |needs 2 votes
Target Milestone|Undefined |3.2.3
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.