You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/18 05:04:46 UTC
[GitHub] [calcite] ILuffZhe opened a new pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency
ILuffZhe opened a new pull request #2650:
URL: https://github.com/apache/calcite/pull/2650
This PR adds some old comments and removes "scripting-painless-spi" dependency, which is included in "lang-painless".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency
Posted by GitBox <gi...@apache.org>.
NobiGo commented on a change in pull request #2650:
URL: https://github.com/apache/calcite/pull/2650#discussion_r771798086
##########
File path: elasticsearch/build.gradle.kts
##########
@@ -37,6 +37,9 @@ dependencies {
testImplementation("org.apache.logging.log4j:log4j-api")
testImplementation("org.apache.logging.log4j:log4j-core")
+ // Elasticsearch doesn't export painless script artifact to maven central.
+ // Using 3rd party version (codelibs) only for test.
Review comment:
@ILuffZhe You have some misunderstanding about the @vlsi comment. You can find an example in [https://github.com/gradle/gradle-profiler/blob/master/build.gradle.kts#L33](https://github.com/gradle/gradle-profiler/blob/master/build.gradle.kts#L33)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] ILuffZhe commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency
Posted by GitBox <gi...@apache.org>.
ILuffZhe commented on a change in pull request #2650:
URL: https://github.com/apache/calcite/pull/2650#discussion_r771799669
##########
File path: elasticsearch/build.gradle.kts
##########
@@ -37,6 +37,9 @@ dependencies {
testImplementation("org.apache.logging.log4j:log4j-api")
testImplementation("org.apache.logging.log4j:log4j-core")
+ // Elasticsearch doesn't export painless script artifact to maven central.
+ // Using 3rd party version (codelibs) only for test.
Review comment:
Thanks for your reminder, @NobiGo. I've corrected it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #2650:
URL: https://github.com/apache/calcite/pull/2650#discussion_r771792181
##########
File path: elasticsearch/build.gradle.kts
##########
@@ -37,6 +37,9 @@ dependencies {
testImplementation("org.apache.logging.log4j:log4j-api")
testImplementation("org.apache.logging.log4j:log4j-core")
+ // Elasticsearch doesn't export painless script artifact to maven central.
+ // Using 3rd party version (codelibs) only for test.
Review comment:
Please use `because("...")` instead of comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] ILuffZhe commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency
Posted by GitBox <gi...@apache.org>.
ILuffZhe commented on a change in pull request #2650:
URL: https://github.com/apache/calcite/pull/2650#discussion_r771794448
##########
File path: elasticsearch/build.gradle.kts
##########
@@ -37,6 +37,9 @@ dependencies {
testImplementation("org.apache.logging.log4j:log4j-api")
testImplementation("org.apache.logging.log4j:log4j-core")
+ // Elasticsearch doesn't export painless script artifact to maven central.
+ // Using 3rd party version (codelibs) only for test.
Review comment:
@vlsi I've made some changes if I understand you correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org