You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/30 01:23:44 UTC

[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #20295: feat: Environment tag

lyndsiWilliams commented on code in PR #20295:
URL: https://github.com/apache/superset/pull/20295#discussion_r933535462


##########
superset-frontend/src/views/components/RightMenu.tsx:
##########
@@ -279,7 +282,16 @@ const RightMenu = ({
         />
       )}
       {environmentTag.text && (
-        <Label css={{ borderRadius: '500px' }} color={environmentTag.color}>
+        <Label
+          css={{ borderRadius: '500px' }}

Review Comment:
   ```suggestion
     css={{ borderRadius: `${theme.gridUnit * 125}px` }}
   ```
   A quick theming nit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org