You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/14 12:01:12 UTC
[GitHub] [airflow] potiuk edited a comment on pull request #9816: Helm chart can now place arbitrary config settings in to airflow.cfg
potiuk edited a comment on pull request #9816:
URL: https://github.com/apache/airflow/pull/9816#issuecomment-658139605
I think it looks really bad and is rather unreadable. But I have an out-of-the-box idea.
Why don't we remove the ConfigMap completely and rely exclusively on environment variables?
We can have some of the variables set from helm values, and we should allow to add new ones (globally, for all pods). While we use some of the configuration we are used to, I think there is not much loss to ditch it, and it will be far more readable. I do not see a reason why in helm chart we should stick with the config file and config map if we can do it much more nicely with variables.
We have also this airflow config command that we can always run at the end of initialization (in the init container ????) to dump the config in the "familiar" and nicely grouped way. We can even make it colored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org