You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by eb...@apache.org on 2013/08/07 16:15:45 UTC
svn commit: r1511326 - in /commons/proper/compress/trunk/src:
main/java/org/apache/commons/compress/archivers/dump/
main/java/org/apache/commons/compress/compressors/bzip2/
test/java/org/apache/commons/compress/
Author: ebourg
Date: Wed Aug 7 14:15:45 2013
New Revision: 1511326
URL: http://svn.apache.org/r1511326
Log:
Removed the explicit calls to the default constructor
Modified:
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveException.java
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveException.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveException.java?rev=1511326&r1=1511325&r2=1511326&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveException.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveException.java Wed Aug 7 14:15:45 2013
@@ -35,7 +35,6 @@ public class DumpArchiveException extend
}
public DumpArchiveException(Throwable cause) {
- super();
initCause(cause);
}
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java?rev=1511326&r1=1511325&r2=1511326&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java Wed Aug 7 14:15:45 2013
@@ -127,11 +127,7 @@ public class BZip2CompressorInputStream
* @throws NullPointerException
* if <tt>in == null</tt>
*/
- public BZip2CompressorInputStream(final InputStream in,
- final boolean decompressConcatenated)
- throws IOException {
- super();
-
+ public BZip2CompressorInputStream(final InputStream in, final boolean decompressConcatenated) throws IOException {
this.in = in;
this.decompressConcatenated = decompressConcatenated;
@@ -990,8 +986,6 @@ public class BZip2CompressorInputStream
// ===============
Data(int blockSize100k) {
- super();
-
this.ll8 = new byte[blockSize100k * BZip2Constants.BASEBLOCKSIZE];
}
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream.java?rev=1511326&r1=1511325&r2=1511326&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream.java Wed Aug 7 14:15:45 2013
@@ -376,18 +376,12 @@ public class BZip2CompressorOutputStream
* @see #MIN_BLOCKSIZE
* @see #MAX_BLOCKSIZE
*/
- public BZip2CompressorOutputStream(final OutputStream out,
- final int blockSize)
- throws IOException {
- super();
-
+ public BZip2CompressorOutputStream(final OutputStream out, final int blockSize) throws IOException {
if (blockSize < 1) {
- throw new IllegalArgumentException("blockSize(" + blockSize
- + ") < 1");
+ throw new IllegalArgumentException("blockSize(" + blockSize + ") < 1");
}
if (blockSize > 9) {
- throw new IllegalArgumentException("blockSize(" + blockSize
- + ") > 9");
+ throw new IllegalArgumentException("blockSize(" + blockSize + ") > 9");
}
this.blockSize100k = blockSize;
@@ -1326,8 +1320,6 @@ public class BZip2CompressorOutputStream
int origPtr;
Data(int blockSize100k) {
- super();
-
final int n = blockSize100k * BZip2Constants.BASEBLOCKSIZE;
this.block = new byte[(n + 1 + NUM_OVERSHOOT_BYTES)];
this.fmap = new int[n];
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java?rev=1511326&r1=1511325&r2=1511326&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java Wed Aug 7 14:15:45 2013
@@ -52,7 +52,6 @@ public abstract class AbstractTestCase e
protected ArchiveStreamFactory factory = new ArchiveStreamFactory();
public AbstractTestCase() {
- super();
}
public AbstractTestCase(String name) {
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src:
main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/
test/java/org/apache/commons/compress/
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Aug 7, 2013 at 11:15 AM, Stefan Bodewig <bo...@apache.org> wrote:
> On 2013-08-07, <eb...@apache.org> wrote:
>
> > - public BZip2CompressorInputStream(final InputStream in,
> > - final boolean
> decompressConcatenated)
> > - throws IOException {
> > -
> > + public BZip2CompressorInputStream(final InputStream in, final
> boolean decompressConcatenated) throws IOException {
>
> I'm not sure whether we have any policy on this, but so far I've tried
> to stick with 80 columns max. Maybe that's a sign of me being old
> fashioned, don't know :-)
>
A line length of 120 is common in a lot of Commons components. 120 is
enforced by Checkstyle in some projects. I suggest you do the same here! :)
Gary
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/commons/compress/
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-08-07, Emmanuel Bourg wrote:
> Le 07/08/2013 17:15, Stefan Bodewig a écrit :
>> I'm not sure whether we have any policy on this, but so far I've tried
>> to stick with 80 columns max. Maybe that's a sign of me being old
>> fashioned, don't know :-)
> 80 columns is quite restrictive with today's wide screens and often
> cause excessive wrapping. I usually restrain myself to 120 columns for
> the code and 80 columns for comments.
> Feel free to reformat as you like, you are reading this code more
> frequently than I do.
I can read either. If 120 is common among other components, then I can
live with that.
Thanks
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src:
main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/
test/java/org/apache/commons/compress/
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 07/08/2013 17:15, Stefan Bodewig a écrit :
> I'm not sure whether we have any policy on this, but so far I've tried
> to stick with 80 columns max. Maybe that's a sign of me being old
> fashioned, don't know :-)
80 columns is quite restrictive with today's wide screens and often
cause excessive wrapping. I usually restrain myself to 120 columns for
the code and 80 columns for comments.
Feel free to reformat as you like, you are reading this code more
frequently than I do.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/commons/compress/
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-08-07, <eb...@apache.org> wrote:
> - public BZip2CompressorInputStream(final InputStream in,
> - final boolean decompressConcatenated)
> - throws IOException {
> -
> + public BZip2CompressorInputStream(final InputStream in, final boolean decompressConcatenated) throws IOException {
I'm not sure whether we have any policy on this, but so far I've tried
to stick with 80 columns max. Maybe that's a sign of me being old
fashioned, don't know :-)
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/commons/compress/
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-08-07, <eb...@apache.org> wrote:
> - public BZip2CompressorInputStream(final InputStream in,
> - final boolean decompressConcatenated)
> - throws IOException {
> -
> + public BZip2CompressorInputStream(final InputStream in, final boolean decompressConcatenated) throws IOException {
I'm not sure whether we have any policy on this, but so far I've tried
to stick with 80 columns max. Maybe that's a sign of me being old
fashioned, don't know :-)
Stefan