You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/03 14:37:55 UTC

[GitHub] [nifi] MikeThomsen commented on a diff in pull request #6293: [NIFI-10349] Add maximum object age property to list s3

MikeThomsen commented on code in PR #6293:
URL: https://github.com/apache/nifi/pull/6293#discussion_r962162164


##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##########
@@ -217,6 +217,14 @@ public class ListS3 extends AbstractS3Processor implements VerifiableProcessor {
             .defaultValue("0 sec")
             .build();
 
+    public static final PropertyDescriptor MAX_AGE = new Builder()

Review Comment:
   You need an additional validation in `customValidate` to ensure the MAX_AGE is greater than the MIN_AGE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org