You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Debdyuti-01 (via GitHub)" <gi...@apache.org> on 2024/05/29 00:13:22 UTC
[PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
Debdyuti-01 opened a new pull request, #13252:
URL: https://github.com/apache/pinot/pull/13252
`backward-incompat`
- In _pom.xml_ file, made **Checkstyle plugin** as 'none' at line #1934 to avoid failing of Project Build for Java version 21.0 and above.
- Commented out the **Spotless plugin version 2.43.0** to avoid failing of Project Build for Java version 21.0 and above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed pull request #13252: Disabling checkstyle plugin and Spotless plugin for Java version > 21.0
URL: https://github.com/apache/pinot/pull/13252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #13252:
URL: https://github.com/apache/pinot/pull/13252#issuecomment-2142792107
We do build java with 21. What failure did you encounter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #13252:
URL: https://github.com/apache/pinot/pull/13252#issuecomment-2136573917
I don't think we should comment the plugin.
You can try to detect the jdk version then decide if the plugin should be activated or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org