You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/07/29 11:17:42 UTC

[GitHub] [plc4x-build-tools] splatch opened a new pull request #6: PLC4X-307 Support for custom packages.

splatch opened a new pull request #6:
URL: https://github.com/apache/plc4x-build-tools/pull/6


   Introduced API changes which allows to pass to generator options in form of key value pairs.
   Underlying generator implementation might utilize that for further customization of code output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x-build-tools] splatch commented on pull request #6: PLC4X-307 Support for custom packages.

Posted by GitBox <gi...@apache.org>.
splatch commented on pull request #6:
URL: https://github.com/apache/plc4x-build-tools/pull/6#issuecomment-889124951


   > Possibly we could move the flavour parameter to the options too.
   
   I began working on generators and test suite and it's almost there. The flavor and language is there to stay, cause it makes plugin and code assistance work nicely. Other parameters which are generator specific might go over map. I just hope we will be able to keep these under control over time. I still have nightmares when I walk around swagger/openapi codegen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x-build-tools] chrisdutz commented on pull request #6: PLC4X-307 Support for custom packages.

Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #6:
URL: https://github.com/apache/plc4x-build-tools/pull/6#issuecomment-889072452


   In general this sort of extension eliminates the ability of IntelliJ to be of assistence with filling out the fields. But I think this is a setting which only people using mspec outside of plc4x will need. So I'm ok with that. Just as long as the "default" is set to the internal value. But yes .. it allows us to go a bit more wild without having to release the plugin every time. Possibly we could move the flavour parameter to the options too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x-build-tools] sruehl merged pull request #6: PLC4X-307 Support for custom packages.

Posted by GitBox <gi...@apache.org>.
sruehl merged pull request #6:
URL: https://github.com/apache/plc4x-build-tools/pull/6


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org