[jira] [Commented] (ROCKETMQ-278) Add specified cluster for cluster info cmd

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167446#comment-16167446 ] 

ASF GitHub Bot commented on ROCKETMQ-278:
-----------------------------------------

Github user shroman commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139078626
  
    --- Diff: namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java ---
    @@ -63,11 +65,36 @@ public RouteInfoManager() {
             this.filterServerTable = new HashMap<String, List<String>>(256);
         }
     
    -    public byte[] getAllClusterInfo() {
    -        ClusterInfo clusterInfoSerializeWrapper = new ClusterInfo();
    -        clusterInfoSerializeWrapper.setBrokerAddrTable(this.brokerAddrTable);
    -        clusterInfoSerializeWrapper.setClusterAddrTable(this.clusterAddrTable);
    -        return clusterInfoSerializeWrapper.encode();
    +    public byte[] getAllClusterInfo(String cluster) {
    --- End diff --
    
    You change the signature of the public class here.
    How about having another method -- `public byte[] getAllClusterInfo()`? And you won't need calling `getAllClusterInfo(null)` then too ;)


> Add specified cluster for cluster info cmd
> ------------------------------------------
>
>                 Key: ROCKETMQ-278
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-278
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-client, rocketmq-namesrv, rocketmq-tools
>    Affects Versions: 4.1.0-incubating
>            Reporter: lindzh
>            Assignee: Xiaorui Wang
>             Fix For: 4.2.0-incubating
>
>
> When using mqadmin command clusterlist,it always display all cluster,i want to display specified cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)