You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "phanikumv (via GitHub)" <gi...@apache.org> on 2023/06/16 15:55:42 UTC

[GitHub] [airflow] phanikumv commented on a diff in pull request #31960: Refactor Eks Create Cluster Operator code

phanikumv commented on code in PR #31960:
URL: https://github.com/apache/airflow/pull/31960#discussion_r1232429182


##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -59,7 +59,54 @@
 FARGATE_FULL_NAME = "AWS Fargate profiles"
 
 
-class EksCreateClusterOperator(BaseOperator):

Review Comment:
   Dont we need deprecation warning here, and call the new operator if we remove this class? Otherwise existing DAGs using the `EksCreateClusterOperator` will break right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org