You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Kinga Marton via Review Board <no...@reviews.apache.org> on 2018/07/30 08:42:41 UTC
Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/
-----------------------------------------------------------
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
Diffs
-----
core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
Diff: https://reviews.apache.org/r/68102/diff/1/
Testing
-------
Tested manually.
Added Junit test.
Thanks,
Kinga Marton
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
> On July 30, 2018, 10:46 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java
> > Lines 60-61 (patched)
> > <https://reviews.apache.org/r/68102/diff/1/?file=2065131#file2065131line60>
> >
> > Isn't emitting another message also just after sleep a good idea?
I have added a wake up message as well :)
> On July 30, 2018, 10:46 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
> > Lines 555-574 (patched)
> > <https://reviews.apache.org/r/68102/diff/1/?file=2065132#file2065132line588>
> >
> > Please extract to `private static class ApplicationIdExistsPredicate implements Predicate<Boolean>`.
I have extracted only the part performing the check.
> On July 30, 2018, 10:46 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
> > Lines 708-712 (patched)
> > <https://reviews.apache.org/r/68102/diff/1/?file=2065132#file2065132line774>
> >
> > Please use latest schema version `1.0`.
>
> Peter Cseh wrote:
> I don't think we should give up test coverage for older schemas. We should keep around the old ones in test and make sure to add enough covergave for new schemas when we add them.
I can change here to the new schema, since there are some similar workflows using the old schema.
- Kinga
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206592
-----------------------------------------------------------
On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 9:59 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/2/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by Peter Cseh via Review Board <no...@reviews.apache.org>.
> On July 30, 2018, 10:46 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
> > Lines 708-712 (patched)
> > <https://reviews.apache.org/r/68102/diff/1/?file=2065132#file2065132line774>
> >
> > Please use latest schema version `1.0`.
I don't think we should give up test coverage for older schemas. We should keep around the old ones in test and make sure to add enough covergave for new schemas when we add them.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206592
-----------------------------------------------------------
On July 30, 2018, 8:42 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated July 30, 2018, 8:42 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/1/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206592
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Lines 1781-1782 (patched)
<https://reviews.apache.org/r/68102/#comment289592>
Please remove code comment and extract to a well-named method instead.
core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
Lines 106-121 (patched)
<https://reviews.apache.org/r/68102/#comment289594>
Extract method.
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java
Lines 32 (patched)
<https://reviews.apache.org/r/68102/#comment289596>
`SLEEP_TIME_MILLIS_KEY` is a better name.
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java
Lines 60-61 (patched)
<https://reviews.apache.org/r/68102/#comment289597>
Isn't emitting another message also just after sleep a good idea?
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 544 (patched)
<https://reviews.apache.org/r/68102/#comment289599>
Please remove white space between method name and brackets.
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 555-574 (patched)
<https://reviews.apache.org/r/68102/#comment289600>
Please extract to `private static class ApplicationIdExistsPredicate implements Predicate<Boolean>`.
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 581-588 (patched)
<https://reviews.apache.org/r/68102/#comment289602>
Please extract to `private static class SubWorkflowActionRunningPredicate implements Predicate<Boolean>`.
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 708-712 (patched)
<https://reviews.apache.org/r/68102/#comment289601>
Please use latest schema version `1.0`.
- András Piros
On July 30, 2018, 8:42 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated July 30, 2018, 8:42 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/1/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206739
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 931-932 (patched)
<https://reviews.apache.org/r/68102/#comment289831>
Can be `final`.
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 946-947 (patched)
<https://reviews.apache.org/r/68102/#comment289832>
Can be `final`.
- András Piros
On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 9:59 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/2/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206741
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Aug. 1, 2018, 1:44 p.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 1:44 p.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/3/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 1:44 p.m.)
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
Diff: https://reviews.apache.org/r/68102/diff/3/
Changes: https://reviews.apache.org/r/68102/diff/2-3/
Testing
-------
Tested manually.
Added Junit test.
Thanks,
Kinga Marton
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206740
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68102/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 9:59 a.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
> core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
> core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
>
>
> Diff: https://reviews.apache.org/r/68102/diff/2/
>
>
> Testing
> -------
>
> Tested manually.
> Added Junit test.
>
>
> Thanks,
>
> Kinga Marton
>
>
Re: Review Request 68102: OOZIE-3193 Applications are not killed when
submitted via subworkflow
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 9:59 a.m.)
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Tags were not generated properly for external child jobs launched from subWFs and they were not killed.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/ActionExecutor.java 71bd36ae6
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a1a9671ab
core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java fdca5706e
core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java e074d482f
Diff: https://reviews.apache.org/r/68102/diff/2/
Changes: https://reviews.apache.org/r/68102/diff/1-2/
Testing
-------
Tested manually.
Added Junit test.
Thanks,
Kinga Marton