You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/22 15:04:28 UTC
[GitHub] [incubator-tvm] tqchen opened a new issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
tqchen opened a new issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650
https://github.com/apache/incubator-tvm/pull/5631 Introduces a generic config mechanism to store the pass configuration options. Given that fallback_device is a pas related config, We should probably also migrate PassContext->fallback_device to a special config. e.g.` relay.fallback_device_type` with IntImmNode as its node type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635742328
One potential problem is that it may break downstream deployment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632751624
@tqchen Thanks for reminding. I will take a stab next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632740723
cc @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635745547
Sounds like a good plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635678608
I agree we should do that as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632740723
cc @zhiics @comaniac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635744914
We could mark build_config as deprecation, and remove that API in the next release cycle. In the meanwhile, we should replace all of the current usages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635674079
I realize we may also want to remove `relay.build_config` and directly use PassContext to keep it consistent to tir, but it may invoke a lot of changes. @tqchen thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org