You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2016/05/31 16:08:18 UTC
[GitHub] storm pull request: [STORM-1872]Release Jedis connection when topology shutd...
GitHub user darionyaphet opened a pull request:
https://github.com/apache/storm/pull/1455
[STORM-1872]Release Jedis connection when topology shutdown
[STORM-1872](https://issues.apache.org/jira/browse/STORM-1872)
Strom Redis connect should be release when topology shutdown .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darionyaphet/storm STORM-1872
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1455
----
commit 0b78636acdd9954f04aa51471603ed95c0980ac6
Author: darionyaphet <da...@gmail.com>
Date: 2016-05-31T16:06:04Z
release Jedis connection
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1455
The change looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1455: [STORM-1872]Release Jedis connection when topology...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1455
@HeartSaVioR done ! travis ci started and working .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1455: [STORM-1872]Release Jedis connection when topology...
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on a diff in the pull request:
https://github.com/apache/storm/pull/1455#discussion_r68033224
--- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsInstanceContainer.java ---
@@ -34,4 +36,10 @@
* @param jedisCommands borrowed instance
*/
void returnInstance(JedisCommands jedisCommands);
+
+ /**
+ * Release Jedis Connection
--- End diff --
update to "Release Container"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1455: [STORM-1872]Release Jedis connection when topology...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1455#discussion_r68027394
--- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsInstanceContainer.java ---
@@ -34,4 +36,10 @@
* @param jedisCommands borrowed instance
*/
void returnInstance(JedisCommands jedisCommands);
+
+ /**
+ * Release Jedis Connection
--- End diff --
It should be closing container, not Jedis connection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1455
@darionyaphet Could you rebase it to recent master to trigger build? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---