You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/02 14:48:36 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4309: Move lombok dependency into root dependency manager for easier version management

wu-sheng commented on a change in pull request #4309:  Move lombok dependency into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373851569
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -275,6 +276,12 @@
                 <version>${powermock.version}</version>
                 <scope>test</scope>
             </dependency>
+            <dependency>
 
 Review comment:
   That depends on how you use it. Logically, they are the same. But `provided` is pointless. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services