You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/06/10 07:37:52 UTC
[GitHub] [mynewt-core] KKopyscinski opened a new pull request #2311: kernel/os: added package dependency
KKopyscinski opened a new pull request #2311:
URL: https://github.com/apache/mynewt-core/pull/2311
If RTT was enabled, rtt/SEGGER_RTT.h was being included
in os.c, but that package was lacking, causing build error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2311: kernel/os: added package dependency
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2311:
URL: https://github.com/apache/mynewt-core/pull/2311#issuecomment-641812317
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] KKopyscinski commented on a change in pull request #2311: kernel/os: added package dependency
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on a change in pull request #2311:
URL: https://github.com/apache/mynewt-core/pull/2311#discussion_r438059353
##########
File path: kernel/os/pkg.yml
##########
@@ -29,6 +29,9 @@ pkg.deps:
- "@apache-mynewt-core/sys/sysinit"
- "@apache-mynewt-core/util/mem"
+pkg.deps.CONSOLE_RTT:
+ - "@apache-mynewt-core/hw/drivers/rtt"
Review comment:
Indeed error was on my side, and this is not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on a change in pull request #2311: kernel/os: added package dependency
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #2311:
URL: https://github.com/apache/mynewt-core/pull/2311#discussion_r438052804
##########
File path: kernel/os/pkg.yml
##########
@@ -29,6 +29,9 @@ pkg.deps:
- "@apache-mynewt-core/sys/sysinit"
- "@apache-mynewt-core/util/mem"
+pkg.deps.CONSOLE_RTT:
+ - "@apache-mynewt-core/hw/drivers/rtt"
Review comment:
`RTT` setting is defined by this package so this dependency does not make any sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] KKopyscinski closed pull request #2311: kernel/os: added package dependency
Posted by GitBox <gi...@apache.org>.
KKopyscinski closed pull request #2311:
URL: https://github.com/apache/mynewt-core/pull/2311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org