You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by Ivan Kelly <iv...@apache.org> on 2012/03/20 16:15:35 UTC

Review Request: BOOKKEEPER-188 Garbage collection code is in the wrong place

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4414/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

This is a very straight forward refactor. The one functional change is that extractMetaFromEntryLogs now call extractMetaFromEntryLog rather than having duplicate logic in each.


This addresses bug BOOKKEEPER-188.
    https://issues.apache.org/jira/browse/BOOKKEEPER-188


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 8da372e 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 23f02bc 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java 96df89a 

Diff: https://reviews.apache.org/r/4414/diff


Testing
-------


Thanks,

Ivan