You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/10/19 10:45:43 UTC
[GitHub] codecov-io edited a comment on issue #4041: Send active-ack after
log collection for nonblocking activations.
codecov-io edited a comment on issue #4041: Send active-ack after log collection for nonblocking activations.
URL: https://github.com/apache/incubator-openwhisk/pull/4041#issuecomment-431318741
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=h1) Report
> Merging [#4041](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0d6c01793af8245965aae96296b385791512fe06?src=pr&el=desc) will **decrease** coverage by `4.87%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4041 +/- ##
==========================================
- Coverage 86.01% 81.13% -4.88%
==========================================
Files 147 147
Lines 7180 7210 +30
Branches 445 444 -1
==========================================
- Hits 6176 5850 -326
- Misses 1004 1360 +356
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `94.02% <100%> (+0.16%)` | :arrow_up: |
| [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `84.07% <72%> (-0.14%)` | :arrow_down: |
| [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `64.38% <78.57%> (+2.47%)` | :arrow_up: |
| [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `81.98% <85.71%> (+0.67%)` | :arrow_up: |
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: |
| [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=footer). Last update [0d6c017...997ccd1](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services