You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/07/27 05:02:25 UTC
Re: Review Request 50483: LENS-1239 : Fix test failures because of
restarts in test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50483/
-----------------------------------------------------------
(Updated July 27, 2016, 5:02 a.m.)
Review request for lens.
Summary (updated)
-----------------
LENS-1239 : Fix test failures because of restarts in test cases
Bugs: LENS-1239
https://issues.apache.org/jira/browse/LENS-1239
Repository: lens
Description
-------
Failures are because server has come up only with hive drivers and no jdbc and mock failing drivers. LensJerseyTest.getServerConf() constructs conf with overwrites from subclasses. If subclasses over-write the conf - TestQueryIndependenceFromSessionClose does right now, and if BeforeSuite's setup picks conf from that class, we are seeing failures.
Updated the test classes with proper calls to restart with correct config.
Diffs
-----
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java a55552e
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java bb57614
lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java 3e9ddb8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8be1f89
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java d723596
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 33791ea
Diff: https://reviews.apache.org/r/50483/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 50483: LENS-1239 : Fix test failures because of
restarts in test cases
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50483/#review143679
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On July 27, 2016, 11:24 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50483/
> -----------------------------------------------------------
>
> (Updated July 27, 2016, 11:24 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1239
> https://issues.apache.org/jira/browse/LENS-1239
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failures are because server has come up only with hive drivers and no jdbc and mock failing drivers. LensJerseyTest.getServerConf() constructs conf with overwrites from subclasses. If subclasses over-write the conf - TestQueryIndependenceFromSessionClose does right now, and if BeforeSuite's setup picks conf from that class, we are seeing failures.
>
> Updated the test classes with proper calls to restart with correct config.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4df2b9b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java a55552e
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java bb57614
> lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java 3e9ddb8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8be1f89
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java d723596
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 33791ea
>
> Diff: https://reviews.apache.org/r/50483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50483: LENS-1239 : Fix test failures because of
restarts in test cases
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50483/#review143681
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java (line 402)
<https://reviews.apache.org/r/50483/#comment209564>
Do we need to restart again with original conf after test ?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java (line 134)
<https://reviews.apache.org/r/50483/#comment209565>
Do we need to restart again with orignal conf after test ?
- Puneet Gupta
On July 27, 2016, 5:54 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50483/
> -----------------------------------------------------------
>
> (Updated July 27, 2016, 5:54 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1239
> https://issues.apache.org/jira/browse/LENS-1239
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failures are because server has come up only with hive drivers and no jdbc and mock failing drivers. LensJerseyTest.getServerConf() constructs conf with overwrites from subclasses. If subclasses over-write the conf - TestQueryIndependenceFromSessionClose does right now, and if BeforeSuite's setup picks conf from that class, we are seeing failures.
>
> Updated the test classes with proper calls to restart with correct config.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4df2b9b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java a55552e
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java bb57614
> lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java 3e9ddb8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8be1f89
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java d723596
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 33791ea
>
> Diff: https://reviews.apache.org/r/50483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50483: LENS-1239 : Fix test failures because of
restarts in test cases
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50483/#review143703
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On July 27, 2016, 7:46 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50483/
> -----------------------------------------------------------
>
> (Updated July 27, 2016, 7:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1239
> https://issues.apache.org/jira/browse/LENS-1239
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failures are because server has come up only with hive drivers and no jdbc and mock failing drivers. LensJerseyTest.getServerConf() constructs conf with overwrites from subclasses. If subclasses over-write the conf - TestQueryIndependenceFromSessionClose does right now, and if BeforeSuite's setup picks conf from that class, we are seeing failures.
>
> Updated the test classes with proper calls to restart with correct config.
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c3f01d5
> lens-client/src/test/resources/lens-site.xml PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4df2b9b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java a55552e
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java bb57614
> lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java 3e9ddb8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8be1f89
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java d723596
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 33791ea
>
> Diff: https://reviews.apache.org/r/50483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50483: LENS-1239 : Fix test failures because of
restarts in test cases
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50483/
-----------------------------------------------------------
(Updated July 27, 2016, 7:46 a.m.)
Review request for lens.
Changes
-------
Fixed test failures and review comments
Bugs: LENS-1239
https://issues.apache.org/jira/browse/LENS-1239
Repository: lens
Description
-------
Failures are because server has come up only with hive drivers and no jdbc and mock failing drivers. LensJerseyTest.getServerConf() constructs conf with overwrites from subclasses. If subclasses over-write the conf - TestQueryIndependenceFromSessionClose does right now, and if BeforeSuite's setup picks conf from that class, we are seeing failures.
Updated the test classes with proper calls to restart with correct config.
Diffs (updated)
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java c3f01d5
lens-client/src/test/resources/lens-site.xml PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4df2b9b
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java a55552e
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java bb57614
lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java 3e9ddb8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8be1f89
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java d723596
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 33791ea
Diff: https://reviews.apache.org/r/50483/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 50483: LENS-1239 : Fix test failures because of
restarts in test cases
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50483/
-----------------------------------------------------------
(Updated July 27, 2016, 5:54 a.m.)
Review request for lens.
Changes
-------
Have seen one more failure in local build :
org.apache.lens.server.query.TestQueryConstraints.setupTest (from TestSuite)
Error Message
Could not recover from persisted state
Stacktrace
java.lang.RuntimeException: Could not recover from persisted state
at org.apache.lens.server.api.query.DriverSelectorQueryContext.setDriverQuery(DriverSelectorQueryContext.java:175)
at org.apache.lens.server.api.query.AbstractQueryContext.setDriverQuery(AbstractQueryContext.java:450)
at org.apache.lens.server.query.QueryExecutionServiceImpl.readExternal(QueryExecutionServiceImpl.java:2843)
at org.apache.lens.server.LensServices.setupPersistedState(LensServices.java:337)
at org.apache.lens.server.LensServices.init(LensServices.java:270)
at org.apache.lens.server.LensJerseyTest.restartLensServer(LensJerseyTest.java:251)
at org.apache.lens.server.LensJerseyTest.restartLensServer(LensJerseyTest.java:237)
at org.apache.lens.server.query.TestQueryConstraints.setupTest(TestQueryConstraints.java:103)
27 Jul 2016 05:22:39 [1e2a0510-c844-4c46-9e7b-a115259b36ec] [main] ERROR org.apache.lens.server.LensServices - Could not recover from persisted state
java.lang.NullPointerException: null
at org.apache.lens.server.api.query.DriverSelectorQueryContext.setDriverQuery(DriverSelectorQueryContext.java:175) ~[lens-server-api-2.6.0-beta-SNAPSHOT.jar:2.6.0-beta-SNAPSHOT]
at org.apache.lens.server.api.query.AbstractQueryContext.setDriverQuery(AbstractQueryContext.java:450) ~[lens-server-api-2.6.0-beta-SNAPSHOT.jar:2.6.0-beta-SNAPSHOT]
at org.apache.lens.server.query.QueryExecutionServiceImpl.readExternal(QueryExecutionServiceImpl.java:2843) ~[classes/:na]
Updated patch fixed the failure.
Bugs: LENS-1239
https://issues.apache.org/jira/browse/LENS-1239
Repository: lens
Description
-------
Failures are because server has come up only with hive drivers and no jdbc and mock failing drivers. LensJerseyTest.getServerConf() constructs conf with overwrites from subclasses. If subclasses over-write the conf - TestQueryIndependenceFromSessionClose does right now, and if BeforeSuite's setup picks conf from that class, we are seeing failures.
Updated the test classes with proper calls to restart with correct config.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4df2b9b
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java a55552e
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java b651b79
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java bb57614
lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java 3e9ddb8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java 8be1f89
lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java d723596
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 33791ea
Diff: https://reviews.apache.org/r/50483/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu