[GitHub] [incubator-superset] xrmx commented on a change in pull request #6356: added filter on databaseView that filters databases based on access in roles

[GitBox <gi...@apache.org>]

xrmx commented on a change in pull request #6356: added filter on databaseView that filters databases based on access in roles
URL: https://github.com/apache/incubator-superset/pull/6356#discussion_r272634357
 
 

 ##########
 File path: superset/security.py
 ##########
 @@ -111,6 +111,10 @@ def all_datasource_access(self):
     def all_database_access(self):
         return self.can_access('all_database_access', 'all_database_access')
 
+    def all_database_access(self):
 
 Review comment:
   Isn't this the very same method as the one above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org