You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/25 19:06:31 UTC

[GitHub] [lucene-solr] zacharymorn opened a new pull request #2433: LUCENE-9639: Implements SimpleTextVectorReader#ramBytesUsed

zacharymorn opened a new pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433


   # Description
   
   Fix nightly test failure by implementing  SimpleTextVectorReader#ramBytesUsed
   
   # Tests
   Passed nightly tests in `TestSimpleTextVectorFormat`
   ```
   xichen@Xis-MacBook-Pro lucene-solr % ./gradlew  :lucene:codecs:test --tests="org.apache.lucene.codecs.simpletext.TestSimpleTextVectorFormat" -Ptests.nightly=true
   
   > Task :randomizationInfo
   Running tests with randomization seed: tests.seed=7B222A36847DE944
   
   > Task :lucene:codecs:test
   :lucene:codecs:test (SUCCESS): 40 test(s), 1 skipped
   The slowest tests (exceeding 500 ms) during this run:
      5.71s TestSimpleTextVectorFormat.testRamBytesUsed (:lucene:codecs)
   
   BUILD SUCCESSFUL in 12s
   16 actionable tasks: 9 executed, 7 up-to-date
   ```
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2433: LUCENE-9639: Implements SimpleTextVectorReader#ramBytesUsed

Posted by GitBox <gi...@apache.org>.
msokolov commented on a change in pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#discussion_r583149084



##########
File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextVectorReader.java
##########
@@ -37,10 +37,7 @@
 import org.apache.lucene.store.ChecksumIndexInput;
 import org.apache.lucene.store.IOContext;
 import org.apache.lucene.store.IndexInput;
-import org.apache.lucene.util.BytesRef;
-import org.apache.lucene.util.BytesRefBuilder;
-import org.apache.lucene.util.IOUtils;
-import org.apache.lucene.util.StringHelper;
+import org.apache.lucene.util.*;

Review comment:
       hmm let's not use * imports please




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2433: LUCENE-9639: Implements SimpleTextVectorReader#ramBytesUsed

Posted by GitBox <gi...@apache.org>.
zacharymorn commented on a change in pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#discussion_r583310433



##########
File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextVectorReader.java
##########
@@ -37,10 +37,7 @@
 import org.apache.lucene.store.ChecksumIndexInput;
 import org.apache.lucene.store.IOContext;
 import org.apache.lucene.store.IndexInput;
-import org.apache.lucene.util.BytesRef;
-import org.apache.lucene.util.BytesRefBuilder;
-import org.apache.lucene.util.IOUtils;
-import org.apache.lucene.util.StringHelper;
+import org.apache.lucene.util.*;

Review comment:
       Ops sorry, updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] msokolov merged pull request #2433: LUCENE-9639: Implements SimpleTextVectorReader#ramBytesUsed

Posted by GitBox <gi...@apache.org>.
msokolov merged pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] msokolov commented on pull request #2433: LUCENE-9639: Implements SimpleTextVectorReader#ramBytesUsed

Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#issuecomment-786368210


   Thanks! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] zacharymorn commented on pull request #2433: LUCENE-9639: Implements SimpleTextVectorReader#ramBytesUsed

Posted by GitBox <gi...@apache.org>.
zacharymorn commented on pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#issuecomment-786334969


   hi @mayya-sharipova, I just ran the command you provided in the jira ticket against the change, and it now passed as well. 
   
   ```
   xichen@Xis-MacBook-Pro lucene-solr % ./gradlew test --tests TestSimpleTextVectorFormat.testRamBytesUsed -Dtests.seed=48CFADC25A84DABC -Dtests.nightly=true -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=eo -Dtests.timezone=America/Tegucigalpa -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   
   
   
   > Task :randomizationInfo
   Running tests with randomization seed: tests.seed=48CFADC25A84DABC
   
   BUILD SUCCESSFUL in 5s
   269 actionable tasks: 49 executed, 220 up-to-date
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org