[GitHub] [arrow] rok commented on a diff in pull request #14293: ARROW-17799: [C++][Parquet] Add DELTA_LENGTH_BYTE_ARRAY encoder to Parquet writer

["rok (via GitHub)" <gi...@apache.org>]

rok commented on code in PR #14293:
URL: https://github.com/apache/arrow/pull/14293#discussion_r1087832547


##########
cpp/src/parquet/encoding.cc:
##########
@@ -3055,6 +3149,14 @@ std::unique_ptr<Encoder> MakeEncoder(Type::type type_num, Encoding::type encodin
             "DELTA_BINARY_PACKED encoder only supports INT32 and INT64");
         break;
     }
+  } else if (encoding == Encoding::DELTA_LENGTH_BYTE_ARRAY) {
+    switch (type_num) {
+      case Type::BYTE_ARRAY:
+        return std::unique_ptr<Encoder>(new DeltaLengthByteArrayEncoder(descr, pool));
+      default:
+        throw ParquetException("DELTA_LENGTH_BYTE_ARRAY only supports BYTE_ARRAY");
+        break;

Review Comment:
   Good point. Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org