You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by tom-mi <gi...@git.apache.org> on 2017/08/19 11:39:27 UTC
[GitHub] groovy pull request #588: Return 404 for non-existing paths in `TemplateServ...
GitHub user tom-mi opened a pull request:
https://github.com/apache/groovy/pull/588
Return 404 for non-existing paths in `TemplateServlet` when running from .war
When `TemplateServlet` was used in application servers that don't unpack a war (i.e. when the real path of resources could not be retrieved), an internal server error was returned upon trying to retrieve a non-existing template file. I had this problem on payara micro.
With this fix, a 404 is returned instead.
When running from a unpacked war, this had already worked before.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tom-mi/groovy master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #588
----
commit 5340188ed39ff60d54cc7b75f418602651889b0f
Author: Thomas Reifenberger <to...@users.noreply.github.com>
Date: 2017-08-17T21:11:30Z
Return 404 for non-existing paths in TemplateServlet when running from .war
- When TemplateServlet was used in application servers that don't unpack
a war (i.e. when the real path of resources could not be retrieved),
an internal server error was returned upon trying to retrieve a
non-existing template file. Now, a 404 is returned.
- When running from a unpacked war, this had already worked before.
commit e38e93d206b61778f397426a2fed57033595c03e
Author: Thomas Reifenberger <to...@users.noreply.github.com>
Date: 2017-08-19T09:59:15Z
Add missing license header to new test class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #588: Return 404 for non-existing paths in `TemplateServ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---