You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/26 16:34:44 UTC
[GitHub] [hadoop-ozone] sodonnel opened a new pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
sodonnel opened a new pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608
## What changes were proposed in this pull request?
This adds a new robot test to the network-topology environment, which:
1. Creates a volume, bucket and key.
2. Stops 1 rack and ensures the data is still readable
3. Restart the rack and stop the other rack and again check the data is readable
That way we can have some confidence the data is being written to both racks OK.
One issue with a test like this on a small cluster, is that there is a high chance the data will end up on 2 racks naturally, even if no network topology is configured. If that was the case, we would expect intermittent test failures.
However, if network topology is working fine, then we would not expect any failures.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3084
## How was this patch tested?
Ran the new smoke test locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
elek commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-595349642
We can rename `test.sh` to something else and commit this patch. In this case we will have a test but won't be picked app by the acceptance tests.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-595354559
> We can rename `test.sh` to something else and commit this patch. In this case we will have a test but won't be picked app by the acceptance tests.
>
> What do you think?
The test.sh here is not completely new, as there was some existing logic in it already. We could raise a new Jira and comment out the lines for the new tests in test.sh (with that Jira number in the comment) and then I could revisit it when we get the blockers fixed. If you are happy with that, let me know and I will push a commit to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-597517556
@adoroszlai has approved this one, so I will go ahead and commit it, and we can get the new test enabled via HDDS-3135 when the blockers are resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r385101523
##########
File path: hadoop-ozone/dist/src/main/compose/testlib.sh
##########
@@ -124,6 +124,23 @@ execute_command_in_container(){
set +e
}
+## @description Stop a list of named containers
+## @param List of container names, eg datanode_1 datanode_2
+stop_containers() {
+ set -e
+ docker-compose -f "$COMPOSE_FILE" stop $@
Review comment:
```suggestion
docker-compose -f "$COMPOSE_FILE" --no-ansi stop $@
```
Please add `--no-ansi` to avoid funky characters in the output:
```
2020-02-26T17:01:00.9125703Z [3BStarting datanode_1 ...
2020-02-26T17:01:00.9127089Z Starting datanode_2 ...
2020-02-26T17:01:00.9128127Z Starting datanode_3 ...
2020-02-26T17:01:01.4869851Z [1A[2K
2020-02-26T17:01:01.4870604Z Starting datanode_3 ... [32mdone[0m
2020-02-26T17:01:01.5357903Z [1B[3A[2K
2020-02-26T17:01:01.5359166Z Starting datanode_1 ... [32mdone[0m
2020-02-26T17:01:01.6387370Z [3B[2A[2K
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-593524065
/pending "I still believe this test will fail intermittently due to HDDS-3116 and HDDS-3107. Therefore we should not merge this until those issues have been resolved."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-593514638
All checks have passed on this PR, however I still believe this test will fail intermittently due to HDDS-3116 and HDDS-3107. Therefore we should not merge this until those issues have been resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r385101636
##########
File path: hadoop-ozone/dist/src/main/compose/testlib.sh
##########
@@ -124,6 +124,23 @@ execute_command_in_container(){
set +e
}
+## @description Stop a list of named containers
+## @param List of container names, eg datanode_1 datanode_2
+stop_containers() {
+ set -e
+ docker-compose -f "$COMPOSE_FILE" stop $@
+ set +e
+}
+
+
+## @description Start a list of named containers
+## @param List of container names, eg datanode_1 datanode_2
+start_containers() {
+ set -e
+ docker-compose -f "$COMPOSE_FILE" start $@
Review comment:
```suggestion
docker-compose -f "$COMPOSE_FILE" --no-ansi start $@
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r385099809
##########
File path: hadoop-ozone/dist/src/main/smoketest/topology/readdata.robot
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation Smoketest ozone cluster startup
+Library OperatingSystem
+Library BuiltIn
+Resource ../commonlib.robot
+
+*** Variables ***
+
+
+*** Test Cases ***
+Read data from previously created key
+ ${output} = Execute ozone sh key get /topvol1/bucket1/key1
Review comment:
```suggestion
${output} = Execute ozone sh key get /topvol1/bucket1/key1 /tmp/key1
```
The `key get` command requires local filename as second argument, so currently it produces this output (trimmed) and does not really verify ability to read data:
```
Missing required parameter: <fileName>
```
Note that on the second run (for the other rack) it will refuse to overwrite `/tmp/key1`, so
1. delete local file after `key get` OR
2. run test case in different container (eg. `om`) OR
3. use random local filename ([example](https://github.com/apache/hadoop-ozone/blob/912dcf0dcbcfb48952443e54f56b33695c413eee/hadoop-ozone/dist/src/main/smoketest/ozonefs/hadoopo3fs.robot#L29) for random string generation)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-596448230
/ready
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r385249422
##########
File path: hadoop-ozone/dist/src/main/compose/testlib.sh
##########
@@ -124,6 +124,23 @@ execute_command_in_container(){
set +e
}
+## @description Stop a list of named containers
+## @param List of container names, eg datanode_1 datanode_2
+stop_containers() {
+ set -e
+ docker-compose -f "$COMPOSE_FILE" stop $@
+ set +e
+}
+
+
+## @description Start a list of named containers
+## @param List of container names, eg datanode_1 datanode_2
+start_containers() {
+ set -e
+ docker-compose -f "$COMPOSE_FILE" start $@
Review comment:
Of course, I had noticed this in other commands but forgot to add the switch to my new ones. I will add it in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r385723958
##########
File path: hadoop-ozone/dist/src/main/compose/ozone-topology/test.sh
##########
@@ -33,6 +33,20 @@ execute_robot_test scm basic/basic.robot
execute_robot_test scm topology/scmcli.robot
+# Ensure data can be read even when a full rack
+# is stopped.
+execute_robot_test scm topology/loaddata.robot
+
+stop_containers datanode_1 datanode_2 datanode_3
+
+execute_robot_test scm topology/readdata.robot
+
+start_containers datanode_1 datanode_2 datanode_3
+
+stop_containers datanode_4 datanode_5 datanode_6
+
Review comment:
what about if datanode_1, datanode_2 and datnaode_3 are not yet started / registered but 4-6 are stopped. Do we need some safety check here?
In the `testlib.sh/start_docker_env` we have a `wait_for_safemode_exit` part. We might need it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r386301912
##########
File path: hadoop-ozone/dist/src/main/compose/ozone-topology/test.sh
##########
@@ -33,6 +33,20 @@ execute_robot_test scm basic/basic.robot
execute_robot_test scm topology/scmcli.robot
+# Ensure data can be read even when a full rack
+# is stopped.
+execute_robot_test scm topology/loaddata.robot
+
+stop_containers datanode_1 datanode_2 datanode_3
+
+execute_robot_test scm topology/readdata.robot
+
+start_containers datanode_1 datanode_2 datanode_3
+
+stop_containers datanode_4 datanode_5 datanode_6
+
Review comment:
Looking at some of the intermittent failures, I think we do need a safety check, but the safemode check will not do it. I believe we need to wait for the xceiver port on the DNs to come up. I have a plan for this which I will post shortly.
However we will still need HDDS-3107 as that is another reason this test can fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on issue #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#issuecomment-592502782
I have pushed a change to address the review comments, however this test is failing intermittently locally, so do not commit even if it comes back as all green.
I think the failures are highlighting issues with the network topology implementation, rather than a problem with the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #608: HDDS-3084 - Extended Network Topology Robot tests to attempted to read data when …
URL: https://github.com/apache/hadoop-ozone/pull/608#discussion_r385248726
##########
File path: hadoop-ozone/dist/src/main/smoketest/topology/readdata.robot
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation Smoketest ozone cluster startup
+Library OperatingSystem
+Library BuiltIn
+Resource ../commonlib.robot
+
+*** Variables ***
+
+
+*** Test Cases ***
+Read data from previously created key
+ ${output} = Execute ozone sh key get /topvol1/bucket1/key1
Review comment:
Well spotted. I will add a random filename using the example you gave.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel merged pull request #608: HDDS-3084. Extend
network topology acceptance test to read data when datanodes are stopped.
Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #608: HDDS-3084. Extend network topology acceptance test to read data when datanodes are stopped.
URL: https://github.com/apache/hadoop-ozone/pull/608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org